Skip to:
Content

BuddyPress.org

#8887 closed defect (bug) (fixed)

String Inconsistencyusage between "Visit" and "View" in BP Groups admin page help overview and list table link

Reported by: lenasterg's profile lenasterg Owned by: slaffik's profile slaFFik
Milestone: 12.0.0 Priority: low
Severity: minor Version:
Component: I18N Keywords: good-first-bug has-patch
Cc:

Description

There is an inconsistency in the usage of the strings "Visit" and "View" in two different files which are used in the Groups admin page.

In the
https://buddypress.trac.wordpress.org/browser/trunk/src/bp-groups/bp-groups-admin.php#L237, the string "Visit" is used to indicate the link the user should click in order to view the group in frontend.
However, in the
https://buddypress.trac.wordpress.org/browser/trunk/src/bp-groups/classes/class-bp-groups-list-table.php#L611, the string "View" is used as text to the link. This inconsistency can cause confusion for users, specially in non-English sites.

Could you update the string usage to use a consistent term between those two files?
I would suggest to use "View" to indicate the link to the group's frontend page in both files, as this is a more commonly used term in similar contexts. This will help users to easily understand the function of the link and improve the overall user experience.

Thanks in advance,
Lena

Change History (3)

#1 @imath
10 months ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to 12.0.0

Good catch, we’ll have it fixed in next major as it touching translations.

This ticket was mentioned in PR #100 on buddypress/buddypress by @imath.


10 months ago
#2

  • Keywords has-patch added; needs-patch removed

Improve consistency about Viewing a group action: use View instead of Visit.

Trac ticket: https://buddypress.trac.wordpress.org/ticket/8887

#3 @imath
10 months ago

  • Resolution set to fixed
  • Status changed from new to closed

In 13482:

Improve group viewing action labelling consistency

Use "view" instead of "visit" to label the group viewing action.

Props lenasterg

Fixes #8887
Closes https://github.com/buddypress/buddypress/pull/100

Note: See TracTickets for help on using tickets.