Filter to stop assets loading outside of BuddyPress Core is not working

[DeFries]

Inside a WordPress multi-site environment, I have BuddPress network activated. I've added the following to the top of my bp-custom.php file:

/**
 * Stop loading BuddyPress assets in places where that's not needed.
 */
add_filter( 'bp_enqueue_assets_in_bp_pages_only', '__return_true' );

However, the assets are still loaded everywhere. There's no change in what's loaded. Full context: the root of the site is a subdomain of the multi-site, and I'm checking a domain-mapped subsite's frontpage. I've added a screenshot of what I'm still seeing be loaded.

[DeFries]

Screenprint of the site's source code.

[imath]

Hi @DeFries

Thanks a lot for your feedback 😍. It’s actually another issue, the filter is avoiding loading the template pack assets (the big buddypress.js & css).

I agree we should also load BP Block assets when they are used only. We’ll try to work on this moving to Block API v2 during 12.0.0 dev cycle.

[DeFries]

Ah, okay. My assumption was indeed that these stylesheets would also not be loaded where they didn't make any sense to be loaded.

Looking forward to 12.0.0 then ☺️.

[imath]

In 13440:

BP Blocks: introduce a new $metadata argument to use WP Block API v2

The bp_register_block() array of arguments now accepts a $metadata
argument to inform about the path to a block block.json dir path. If
it's used this function is now is simple wrapper of WordPress's
register_block_type_from_metadata() function.

Closes ​https://github.com/buddypress/buddypress/pull/76
See #8842
See #8457
Fixes #8855

[imath]

In 13464:

Update all BP Blocks & Modern JS PHP registration code

• Use the metadata argument of the bp_register_block() function to load all BP Blocks JSON files.
• Get BP Blocks dependencies using the @wordpress/scripts index.asset.php generated files.
• Although the BP Blocks category has been replaced by the BP Blocks collection, leave the no more used bp_block_category() function in place in case some third party plugins are using it for their custom blocks.
• PHPUnit tests: make sure to unregister all BP Blocks when using the BP_UnitTestCase->go_to() method.

See #8842
Fixes #8457
Closes ​https://github.com/buddypress/buddypress/pull/92

[imath]

These BP Block styles are only loaded when used in Block themes, but regular themes are still loading them everywhere. I can't remember if WordPress is providing a way to avoid this in regular themes. If someone can give me the documentation/make link I'll be happy to come back on this ticket. In the meantime, moving this ticket in awaiting-contributions.