Skip to:
Content

BuddyPress.org

Opened 2 years ago

Closed 5 months ago

#8775 closed defect (bug) (fixed)

Access to wp-signup.php should be allowed when Sites component is not active

Reported by: needle's profile needle Owned by: espellcaste's profile espellcaste
Milestone: 15.0.0 Priority: normal
Severity: normal Version:
Component: Members Keywords: has-patch
Cc:

Description

When the BuddyPress Sites component is not active, access to wp-signup.php should be allowed for logged-in users when the WordPress settings are appropriately set.

At present, bp_core_wpsignup_redirect() redirects away unless:

  1. The stage POST variable is set to gimmeanotherblog
  2. Access is attempted via wp-admin/my-sites.php

It is possible for front-end menus to have links to wp-signup.php - but when the Sites component is not active, these will be redirected to bp_get_signup_page() and from there the the site homepage.

This means that wp-admin/my-sites.php is the only route through which logged-in users can create additional sites.

Attachments (1)

8775.patch (968 bytes) - added by needle 2 years ago.
Fixes #8775

Download all attachments as: .zip

Change History (6)

@needle
2 years ago

Fixes #8775

#1 @espellcaste
6 months ago

  • Milestone changed from Awaiting Review to Up Next
  • Owner set to espellcaste
  • Status changed from new to assigned

I'll look into this myself.

#2 @imath
5 months ago

  • Milestone changed from Up Next to 15.0.0

#3 @espellcaste
5 months ago

@needle I was able to replicate the issue. I'll test your patch to confirm it doesn't introduce regressions.

This ticket was mentioned in PR #329 on buddypress/buddypress by renatonascalves.


5 months ago
#4

  • Keywords has-patch added

#5 @espellcaste
5 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 13982:

Allow access to the wp-signup.php page when the Site Tracking component is not active.

Access to the https://wp.test/wp-signup.php page is allowed when the Site Tracking component *is not* active.

Props needle.

Fixes #8775
Closes https://github.com/buddypress/buddypress/pull/329

Note: See TracTickets for help on using tickets.