Skip to:
Content

BuddyPress.org

Opened 2 years ago

Closed 2 years ago

Last modified 5 weeks ago

#8678 closed defect (bug) (fixed)

Confirmed: Function bp_get_group_avatar_url No Longer Returns Raw URL – 10.0.0+

Reported by: mackey1's profile mackey1 Owned by: imath's profile imath
Milestone: 10.3.0 Priority: normal
Severity: normal Version: 10.0.0
Component: Groups Keywords: has-patch
Cc: @…

Description

The output format for text returning from function bp-groups-bp_get_group_avatar_url has changed between 9.2.0 and 10.0.0.

The output used to produce a raw URL text, but now it produces img HTML text.

This behaviour was confirmed by @shanebp in the original "How-to & Troubleshooting" support ticket found at ...

https://buddypress.org/support/topic/function-bp_get_group_avatar_url-no-longer-returns-raw-url-10-0-0-2/

Please review @shanebp's comment "A parameter for $html is missing and defaults to true." and fix.

Thank you.

Attachments (1)

8678.patch (650 bytes) - added by imath 2 years ago.

Download all attachments as: .zip

Change History (5)

@imath
2 years ago

#1 @imath
2 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 10.3.0

Thanks for your report @mackey1 I believe 8678.patch is fixing the issue. I'll run some complementary tests to be 100% sure.

#2 @imath
2 years ago

In 13267:

Make sure bp_get_group_avatar_url() returns the group avatar raw URL

In r13085 a regression was introduced making this function wrongly return
the avatar <img> html output instead of the avatar raw URL. As the
html attribute of the bp_get_group_avatar() defaults to true we need
to set it to false when using this function from
bp_get_group_avatar_url().

Props mackey1, shanebp

See #8678 (trunk)

#3 @imath
2 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 13268:

Make sure bp_get_group_avatar_url() returns the group avatar raw URL

In r13085 a regression was introduced making this function wrongly return
the avatar <img> html output instead of the avatar raw URL. As the
html attribute of the bp_get_group_avatar() defaults to true we need
to set it to false when using this function from
bp_get_group_avatar_url().

Props mackey1, shanebp

Fixes #8678 (branch 10.0)

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


5 weeks ago

Note: See TracTickets for help on using tickets.