Pending accounts not showing all field selections when viewing accounts since 10.0

[niftythree]

Hello,

Since updating to 10.0, when reviewing accounts in Users > Manage Signups, some fields (which are actually filled in) show as empty. This does not happen in 9.2.0. Looking further into it, it appears to occur on fields where multiple selections can be made, such as checkboxes and multi select boxes. However, once the account is activated, the fields display fine with all their selections.

We are using the Legacy pack.

Thanks. 🙂

[imath]

Can you refresh my memory I don’t remember we were displaying these fields in 9.2, I think that’s a feature we added in 10.0 (modal box). @dcavins can you look at this?

[dcavins]

I see the issue is a bad self-reference to the formatting function. I'm sure I messed it up while re-prefixing all of the signup functions for the twentieth time. :) Patch to follow.

[dcavins]

Correct reference to bp_members_admin_format_xprofile_field_for_display()

[dcavins]

In 13234:

Correct reference to bp_members_admin_format_xprofile_field_for_display().

When formatting an array-based xprofile field for display,
bp_members_admin_format_xprofile_field_for_display()
should refer to itself using the correct function name.

Props niftythree.

Fixes #8638.

[dcavins]

Thanks @niftythree for the report!

[imath]

Let's make this fix available in 10.1.0, also committing it to the 10.0 branch ☺️

[imath]

In 13237:

Correct reference to bp_members_admin_format_xprofile_field_for_display().

When formatting an array-based xprofile field for display, bp_members_admin_format_xprofile_field_for_display() should refer to itself using the correct function name.

Props niftythree, dcavins.

Fixes #8638 (branch 10.0).