Remove unnecessary arguments in various function calls

[oztaser]

I've found a few function call with more arguments than expected. It would be good if we remove them.

[oztaser]

bp_core_get_userlink expecting 3 arguments, not 4.

[oztaser]

bp_is_widget_block_active expecting 2 arguments, not 3

[oztaser]

We don't need to pass any arguments to these functions.

[imath]

Good catches! Thanks a lot for these improvements.

[oztaser]

has_action expecting 2 arguments, not 3.

[espellcaste]

All patches are good except for 8635.4.diff It is my understanding those priorities were decreased for a reason.

[imath]

@oztaser is right about removing priorities as WordPress do not use it for has_action(). See ​https://developer.wordpress.org/reference/functions/has_action/

I’ll commit the patches shortly.

[imath]

In 13293:

Remove unnecessary 4th argument when using bp_core_get_userlink()

bp_core_get_userlink() only accepts 3 arguments.

Props oztaser

See #8635

[imath]

In 13294:

Remove unnecessary 3rd arg when using bp_is_widget_block_active()

bp_is_widget_block_active() only accepts 2 arguments.

Props oztaser

See #8635

[imath]

In 13295:

Remove unnecessary arg when using functions which don't expect one

bp_get_message_thread_unread_count() & bp_messages_form_action() do
not accept any arguments.

Props oztaser

See #8635

[imath]

In 13296:

Remove unnecessary 3rd argument when using has_action()

has_action() only accepts 2 arguments.

Props oztaser

Fixes #8635