Pagination broken in `BP_Blogs_Blog::get()`

[r-a-y]

In #8488, date queries were added for the blogs component. Also some refactoring was done to the blogs stack so we could pass an array instead of multiple function arguments.

There is a bug during the refactoring that broke pagination when fetching the blogs loop (apologies!). For large sites, this can cause timeouts on the Sites Directory.

In BP_Blogs_Blog::get(), the "per page" argument was previously $limit, while in bp_blogs_get_blogs(), the "per page" argument is $r['per_page']. When swapping to the function array, $r['limit'] doesn't exist, which caused no pagination 😅

I've attached a patch, which fixes this issue.

[imath]

Hi @r-a-y thanks a lot for your patch, it looks good, I'm just wondering if you missed a $limit replacement in the bp_blogs_get_random_blogs() function, could you look at it. Otherwise, it's good to be committed to me 👍

[r-a-y]

I'm just wondering if you missed a $limit replacement in the bp_blogs_get_random_blogs() function, could you look at it.

Ahh, yes. I did miss this replacement. Will add it in when I commit it.

[r-a-y]

In 13235:

Blogs: Fix pagination in BP_Blogs_Blog::get().

As part of #8488, we refactored BP_Blogs_Blog::get() to use an array
as the main function argument instead of passing multiple function
arguments.

In BP_Blogs_Blog::get(), the "per page" argument was previously
$limit, while in bp_blogs_get_blogs(), the "per page" argument
passed to BP_Blogs_Blog::get() is $r['per_page']. When swapping
over to the array function argument, $r['limit'] does not exist,
which broke pagination and would return all blogs instead.

This commit fixes the pagination problem by renaming the array key
from $r['limit'] to $r['per_page'].

Props imath.

Fixes #8633 (10-branch)

[r-a-y]

In 13236:

Blogs: Fix pagination in BP_Blogs_Blog::get().

As part of #8488, we refactored BP_Blogs_Blog::get() to use an array
as the main function argument instead of passing multiple function
arguments.

In BP_Blogs_Blog::get(), the "per page" argument was previously
$limit, while in bp_blogs_get_blogs(), the "per page" argument
passed to BP_Blogs_Blog::get() is $r['per_page']. When swapping
over to the array function argument, $r['limit'] does not exist,
which broke pagination and would return all blogs instead.

This commit fixes the pagination problem by renaming the array key
from $r['limit'] to $r['per_page'].

Props imath.

Fixes #8633 (trunk)