Skip to:
Content

BuddyPress.org

Opened 2 years ago

Closed 19 months ago

#8604 closed defect (bug) (fixed)

Logging activities should adapt to the context they're displayed in

Reported by: imath's profile imath Owned by: imath's profile imath
Milestone: 11.0.0 Priority: normal
Severity: normal Version:
Component: Activity Keywords: has-patch
Cc:

Description

Logging activities (see #8581) should be more dependent on the context they're displayed in:

  1. In the Activity directory page: what they look today
  2. In the User's activity page: logging activity about them should stay without content
  3. In the Group's activity page: instead of the group's avatar/cover it should be the one of the author of the activity.

Attachments (2)

8604.patch (1.4 KB) - added by imath 2 years ago.
8604.2.patch (874 bytes) - added by imath 19 months ago.

Download all attachments as: .zip

Change History (13)

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


2 years ago

@imath
2 years ago

#2 @imath
2 years ago

  • Keywords has-patch added; 2nd-opinion removed

In 8604.patch, I suggest to avoid using generated content activities when viewing a group or a personal stream when the activity type is specific to the displayed group or specific to the displayed member.

About the Group's activity stream, I've changed my mind because my initial thought would require more templating work.

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


2 years ago

#4 @imath
2 years ago

  • Milestone changed from 10.0.0 to Up Next

Let's carry on working on this during next release

#5 @imath
21 months ago

  • Milestone changed from Up Next to 11.0.0

Let's discuss about this during 11.0 dev cycle.

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


21 months ago

#7 @dcavins
21 months ago

This is definitely a nice change. It was not that helpful seeing the user/group banner in each item in a user or group's activity stream. Works for me!

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


21 months ago

#9 @imath
20 months ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 13308:

Activity: restrict rich logging items to the site-wide stream

10.0.0 introduced richer activities about user's interaction with their profile or with groups (eg: user A changed their profile image). Displaying these richer activities into the self user or self group streams is less helpful and we are now restricting this extended version of these activity types to the site-wide activity stream.

Props dcavins

Fixes #8604

#10 @imath
19 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

[13308] introduced a notice error, before trying to get groups_get_current_group()->id we need to make sure a group is displayed

@imath
19 months ago

#11 @imath
19 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 13326:

Improve the way we check the group context of logging activities

[13308] introduced a PHP warning due to a misuse of the
groups_get_current_group() function (my bad!). When no group is
displayed this function returns false, so checking if it's a
BP_Groups_Group object having an id property is wrong.

Fixes #8604

Note: See TracTickets for help on using tickets.