Bug Group Invititation System (Legacy Theme)

[mandro]

Good Day

I found a bug with Legacy Template (this bug does not exist with Nouveau). Please do a test with these steps:

1. User A Send Group Invitation to User B to join Group X

2. And then User B will receive an invitiation. But please do not click link on the notification page.

3. Please go to the Groups Directory and click Join to join Group X. You will see user B can not join that group. The join button can not be clicked. Kindly check screenshots below:

​https://snipboard.io/6fDTPn.jpg

​https://snipboard.io/C0YAlp.jpg

[rommanch]

I'm having this issue on my website too

[imath]

Hi @mandro

I confirm I was able to reproduce the issue. Unlike BP Nouveau, BP Legacy doesn't check what the $_POST['action'] is. It instead checks if the user has an invite and if so forces the action to an accept_invite one.

I have attached a preliminary ​patch to help understand the issue. @dcavins could you have a look at it and improve this ​patch?

[imath]

In 13160:

Legacy: allow invited users to join a group from the Groups Directory

Unlike BP Nouveau, the BP Legacy Template pack wasn't allowing an invited user to directly join a group from the Groups Directory. They had to accept the Group invites. Both template pack are now behaving the same, leaving users to directly join a group without replying to the corresponding group invite.

Props mandro

Fixes #8574