Skip to:
Content

BuddyPress.org

Opened 3 years ago

Closed 3 years ago

#8574 closed defect (bug) (fixed)

Bug Group Invititation System (Legacy Theme)

Reported by: mandro's profile mandro Owned by: dcavins's profile dcavins
Milestone: 10.0.0 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch needs-refresh 2nd-opinion
Cc:

Description

Good Day

I found a bug with Legacy Template (this bug does not exist with Nouveau). Please do a test with these steps:

  1. User A Send Group Invitation to User B to join Group X
  1. And then User B will receive an invitiation. But please do not click link on the notification page.
  1. Please go to the Groups Directory and click Join to join Group X. You will see user B can not join that group. The join button can not be clicked. Kindly check screenshots below:

​https://snipboard.io/6fDTPn.jpg

​https://snipboard.io/C0YAlp.jpg

Attachments (2)

2.jpg​ (18.6 KB) - added by mandro 3 years ago.
8574.patch​ (1.3 KB) - added by imath 3 years ago.

Download all attachments as: .zip

Change History (6)

@mandro
3 years ago

#1 @rommanch
3 years ago

I'm having this issue on my website too

@imath
3 years ago

#2 @imath
3 years ago

  • Keywords has-patch needs-refresh 2nd-opinion added; needs-patch removed
  • Milestone changed from Awaiting Review to 10.0.0
  • Version 9.1.1 deleted

Hi @mandro

I confirm I was able to reproduce the issue. Unlike BP Nouveau, BP Legacy doesn't check what the $_POST['action'] is. It instead checks if the user has an invite and if so forces the action to an accept_invite one.

I have attached a preliminary ​patch to help understand the issue. @dcavins could you have a look at it and improve this ​patch?

#3 @imath
3 years ago

  • Owner set to dcavins
  • Status changed from new to assigned

#4 @imath
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 13160:

Legacy: allow invited users to join a group from the Groups Directory

Unlike BP Nouveau, the BP Legacy Template pack wasn't allowing an invited user to directly join a group from the Groups Directory. They had to accept the Group invites. Both template pack are now behaving the same, leaving users to directly join a group without replying to the corresponding group invite.

Props mandro

Fixes #8574

Note: See TracTickets for help on using tickets.