Skip to:
Content

BuddyPress.org

Opened 3 years ago

Closed 3 years ago

#8554 closed enhancement (fixed)

Mark deprecated query classes arguments as deprecated

Reported by: espellcaste's profile espellcaste Owned by: espellcaste's profile espellcaste
Milestone: 10.0.0 Priority: normal
Severity: normal Version: 9.1.1
Component: Core Keywords: has-patch has-unit-tests
Cc:

Description

There are Query Classes (at BP_Friends_Friendship and BP_Groups_Group, maybe more) and methods which have deprecated arguments but which are not marked as such.

Use ​https://developer.wordpress.org/reference/functions/_deprecated_argument/ and update unit tests.

Attachments (1)

8554-1.diff​ (18.9 KB) - added by espellcaste 3 years ago.

Download all attachments as: .zip

Change History (4)

@espellcaste
3 years ago

#1 @espellcaste
3 years ago

  • Keywords has-patch has-unit-tests added; needs-patch needs-unit-tests removed

#2 @imath
3 years ago

Thanks for working on this 💪

#3 @espellcaste
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 13086:

Marking deprecated query classes, their methods, arguments as deprecated in the BP_Friends_Friendship and BP_Friends_Friendship classes.

Props imath

Fixes #8554 (trunk)

Note: See TracTickets for help on using tickets.