Wrong label text on settings page regarding enable/disable profile syncing

[floriansimeth]

Hey there,
I hope you're all doing well.

I've found out that the explanation for the "profile syncing" checkbox on the settings page is wrong. The correct wording would be "Disable BuddyPress to WordPress profile syncing" instead of "Enable BuddyPress to WordPress profile syncing".

Greetings!
Flo

[floriansimeth]

buddypress/bp-core/admin/bp-core-admin-settings.php.patch

[imath]

Hi @floriansimeth

Thanks a lot for your feedback and patch.

Well actually, the way we are checking this option is a bit misleading I must confess. The checkbox is checked if ! bp_disable_profile_sync() in human words when the disable profile sync option is false. If the option is true, then the checkbox is unchecked. So it is the way it should be.

If you want profile syncing, you need to activate the checkbox. So we don't need to change this 😇.

[floriansimeth]

Hey @imath,
and thanks for your fast reply on this.

Unfortunately I don't get it. I've tested it multiple times now and it seems that syncing does not work when the checkbox is checked. But the description says that sync should work when the checkbox is checked, correct?

Can you please test yourself and confirm, too? I've tested it locally with no other plugins installed.

Thanks a lot
Florian

[imath]

I confirm :) I've just tested it again. Checkbox enabled: profile syncing ✅

NB: only the BP 'Name' field is synced with WordPress display name.

[floriansimeth]

Can you confirm with a custom field (not the default field) that syncs to first and/or last name?

[imath]

No I can't because this is not the purpose of the feature, only the WP display name is synced with the default 'Name' field used by BuddyPress.

If you want to sync first and last or any custom contact methods, you can use the new ​WordPress xProfile Fields we introduced in 8.0.0. These fields are not synced, their value are directly retrieved form/and updated into WordPress users/usermeta db tables.

BTW, We'll need to rethink this sync feature for the display name now we introduced WP xProfile fields.