Bug in bp_nouveau_get_activity_entry_buttons function when bp_nouveau_get_activity_entry_buttons filter returns empty array

[sbrajesh]

Hi,
There is a bug in bp_nouveau_get_activity_entry_buttons()
When a function hooked to filter 'bp_nouveau_get_activity_entry_buttons' returns an empty array( I was trying to hide the action buttons for an activity when it is under moderation), The function return $buttons incorrectly.

This causes php to throw notice and show Array Array Array where action is expected($buttons is multi dimensional array).

The following line

		if ( ! $buttons_group ) {
			return $buttons;
		}

should be changed to

		if ( ! $buttons_group ) {
			return array();
		}

I am not return $buttons_group as the return expects an array and if some code returns incorrect value type, it will cause issue in future.

Please update.

[imath]

Thanks for your report and patch 👌. Let’s include it in next minor release

[sbrajesh]

Thank you for considering it.

[imath]

In 12970:

BP Nouveau: improve the function to get activity action buttons

Right After the filter 'bp_nouveau_get_activity_entry_buttons' the function was wrongly returning an array that wasn't the result of the filter when this result was empty.

In this particular case, we simply need to return an empty array.

Props sbrajesh

See #8484 (trunk)

[imath]

In 12971:

BP Nouveau: improve the function to get activity action buttons

Right After the filter 'bp_nouveau_get_activity_entry_buttons' the function was wrongly returning an array that wasn't the result of the filter when this result was empty.

In this particular case, we simply need to return an empty array.

Props sbrajesh

Fixes #8484 (branch 8.0)

[imath]

Ticket retargeted after milestone deleted