Skip to:
Content

BuddyPress.org

Opened 5 months ago

Closed 4 months ago

Last modified 4 months ago

#8425 closed defect (bug) (fixed)

nouveau doesn't display password box on twenty twenty-one

Reported by: iamthewebb Owned by: imath
Milestone: 7.2.0 Priority: normal
Severity: normal Version: 7.1.0
Component: Templates Keywords: needs-patch
Cc:

Description

buddypress/bp-templates/bp-nouveau/css/twentytwentyone.min.css

#buddypress.twentytwentyone .wp-pwd:not(.is-open) {
	display: none;
}

Hides the password box and currently needs overridden so it will display and allow sign up

Attachments (1)

8425.patch (2.6 KB) - added by imath 5 months ago.

Download all attachments as: .zip

Change History (8)

#1 @imath
5 months ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 7.2.0
  • Owner set to imath
  • Status changed from new to assigned

Hi @iamthewebb

I confirm, thanks a lot for reporting this issue. This rule was added for the user's profile general settings where the pwd field was wrongly displayed. At this place it's needed to click on a button to change the password. It appears we need to narrow how this rule applies to make sure the password field is output into the registration form.

@imath
5 months ago

#2 @imath
5 months ago

In 12834:

BP Nouveau: make sure the registration pwd field is displayed in 2021

Twenty Twenty-One companion stylesheet: narrow how the rule to hide the password into the user's profile general settings is applied.

Props iamthewebb

See #8425 (Trunk)

#3 @imath
5 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 12835:

BP Nouveau: make sure the registration pwd field is displayed in 2021

Twenty Twenty-One companion stylesheet: narrow how the rule to hide the password into the user's profile general settings is applied.

Props iamthewebb

Fixes #8425 (7.0 branch)

#4 @imath
4 months ago

  • Keywords needs-patch added; has-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Ouch I just noticed I made a mistake. Although the commit is fixing the password display on register page, it introduced a wrong behavior into the User's profile setting screen.

#5 @imath
4 months ago

In 12842:

Nouveau: improve password visibility management with Twenty Twenty-One

Using the .my-account body class is too restrictive. Community Administrators might want to edit another user's password. To make this possible, let’s use .settings.general body classes.

Antiprops imath

See #8425

#6 @imath
4 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 12843:

Nouveau: improve password visibility management with Twenty Twenty-One

Using the .my-account body class is too restrictive. Community Administrators might want to edit another user's password. To make this possible, let’s use .settings.general body classes.

Antiprops imath

Fixes #8425 (branch 7.0)

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


4 months ago

Note: See TracTickets for help on using tickets.