nouveau doesn't display password box on twenty twenty-one

[iamthewebb]

buddypress/bp-templates/bp-nouveau/css/twentytwentyone.min.css

#buddypress.twentytwentyone .wp-pwd:not(.is-open) {
	display: none;
}

Hides the password box and currently needs overridden so it will display and allow sign up

[imath]

Hi @iamthewebb

I confirm, thanks a lot for reporting this issue. This rule was added for the user's profile general settings where the pwd field was wrongly displayed. At this place it's needed to click on a button to change the password. It appears we need to narrow how this rule applies to make sure the password field is output into the registration form.

[imath]

In 12834:

BP Nouveau: make sure the registration pwd field is displayed in 2021

Twenty Twenty-One companion stylesheet: narrow how the rule to hide the password into the user's profile general settings is applied.

Props iamthewebb

See #8425 (Trunk)

[imath]

In 12835:

BP Nouveau: make sure the registration pwd field is displayed in 2021

Twenty Twenty-One companion stylesheet: narrow how the rule to hide the password into the user's profile general settings is applied.

Props iamthewebb

Fixes #8425 (7.0 branch)

[imath]

Ouch I just noticed I made a mistake. Although the commit is fixing the password display on register page, it introduced a wrong behavior into the User's profile setting screen.

[imath]

In 12842:

Nouveau: improve password visibility management with Twenty Twenty-One

Using the .my-account body class is too restrictive. Community Administrators might want to edit another user's password. To make this possible, let’s use .settings.general body classes.

Antiprops imath

See #8425

[imath]

In 12843:

Nouveau: improve password visibility management with Twenty Twenty-One

Using the .my-account body class is too restrictive. Community Administrators might want to edit another user's password. To make this possible, let’s use .settings.general body classes.

Antiprops imath

Fixes #8425 (branch 7.0)