Skip to:
Content

BuddyPress.org

Opened 3 years ago

Closed 3 years ago

#8392 closed defect (bug) (fixed)

PHP 8.0 deprecated notice caused by the `BP_Groups_Invitation_Manager->run_acceptance_action()` method

Reported by: imath's profile imath Owned by: imath's profile imath
Milestone: 6.4.0 Priority: normal
Severity: normal Version:
Component: Groups Keywords: has-patch 2nd-opinion
Cc:

Description

This is the same trouble I've fixed for #8390. But this one needs to be fixed before PHP 8.0 release (November 26), so into our 6.4.0 milestone.

BP_Groups_Invitation_Manager->run_acceptance_action() is generating this deprecated notice.

Attachments (2)

8392.patch (1.5 KB) - added by imath 3 years ago.
8392.2.patch (2.0 KB) - added by imath 3 years ago.
This patch is also fixing the deprecated notice of the PHPUnit invitations manager asset

Download all attachments as: .zip

Change History (6)

@imath
3 years ago

@imath
3 years ago

This patch is also fixing the deprecated notice of the PHPUnit invitations manager asset

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


3 years ago

#2 @dcavins
3 years ago

Thanks, @imath! Your patch looks good to me, and definitely won't break anything in BP, where the type is always specified. I can imagine how you could leave the type unspecified, but provide the second argument, anyway. :)

#3 @imath
3 years ago

In 12792:

Groups: Avoid a PHP 8.0 deprecated notice about optional function arg.

The BP_Groups_Invitation_Manager->run_acceptance_action() method was wrongly using one optional arguments before a required one. As PHP 8.0 no longer accepts this practice, all arguments of the method will be required.

See #8392 (branch 6.0)

#4 @imath
3 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 12793:

Groups: Avoid a PHP 8.0 deprecated notice about optional function arg.

The BP_Groups_Invitation_Manager->run_acceptance_action() method was wrongly using one optional arguments before a required one. As PHP 8.0 no longer accepts this practice, all arguments of the method will be required.

Fixes #8392 (trunk)

Note: See TracTickets for help on using tickets.