Skip to:
Content

BuddyPress.org

Opened 6 months ago

Closed 5 months ago

#8372 closed defect (bug) (fixed)

Groups Type Admin UI when BuddyPress is activated on a sub site

Reported by: imath Owned by: imath
Milestone: 7.0.0 Priority: normal
Severity: normal Version:
Component: Groups Keywords: has-patch commit
Cc:

Description

In this case there's 1 extra Groups menu + Groups types submenu. I believe we only need to generate the one that is redirected on the Network admin when the BP root blog is the same than the main Network Site.

Attachments (2)

8372.patch (581 bytes) - added by imath 6 months ago.
8372.2.patch (592 bytes) - added by imath 5 months ago.

Download all attachments as: .zip

Change History (6)

@imath
6 months ago

#1 @imath
6 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 12738:

Make sure the Group Types admin menu is generated once on Multisite

When BuddyPress is activated on a sub site of the Network, the Groups admin page is directly available from this sub site administration. We don't need to generate a new Groups admin menu redirecting to the Network administration.

Fixes #8372

#2 @imath
5 months ago

  • Keywords needs-patch added; has-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

This does not fix the issue when BuddyPress is not network activated but activated on the root site 😬

@imath
5 months ago

#3 @imath
5 months ago

  • Keywords has-patch commit added; needs-patch removed

8372.2.patch is fixing the issue wherever BuddyPress is activated :

  • at the network level,
  • on the main site level,
  • on a sub site level.

#4 @imath
5 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 12777:

Add an extra Groups menu to site's admin if BP is network activated

On multisite configs, as it's not possible to edit tags into the network admin, BuddyPress is generating the sub menu item to manage Group Types into the main site's admin. In this case, and this case only, we also need to generate a parent menu item to redirect the Administrator to the Network Groups admin page.

Fixes #8372

Note: See TracTickets for help on using tickets.