Skip to:
Content

BuddyPress.org

Opened 5 months ago

Last modified 5 months ago

#8327 new defect (bug)

BP_SHOW_AVATARS is using non existing option parameter

Reported by: vapvarun Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Core Keywords: close
Cc:

Description

"show_avatars" does not seem defined as an option value.

define( 'BP_SHOW_AVATARS', bp_get_option( 'show_avatars' ) );

With the current option, if we disable Allow registered members to upload avatars, the change profile photo tab is still visible.
https://drive.google.com/file/d/1zR3AXR1BYoJZ-t1_HsRZgLD_3SqNcIQd/view?usp=sharing

Change History (4)

#1 follow-up: @vapvarun
5 months ago

@imath it should use bp-disable-avatar-uploads instead of show_avatars, values are reversed to display members avatar after applying these edits.

#2 in reply to: ↑ 1 @imath
5 months ago

Replying to vapvarun:

@imath it should use bp-disable-avatar-uploads instead of show_avatars, values are reversed to display members avatar after applying these edits.

I'm unsure @vapvarun because show_avatars is a WordPress option, I believe the purpose of this function is to check whether avatars are allowed into the WordPress site or not. I'll look into it asap ;)

#3 @imath
5 months ago

I just had a look at the screenshot, I believe there's no issue as the message is informing the user can change their avatar updating it from the Gravatar site.

#4 @vapvarun
5 months ago

  • Keywords close added
  • Milestone 7.0.0 deleted

Okay got it, I thought it should disable the tab like Cover Image Tab when unchecked.

Note: See TracTickets for help on using tickets.