Coding Standard : Anchor Tag Closing missing - src/bp-templates/bp-nouveau/buddypress/common/js-templates/invites/index.php

[ankitmaru]

Please check this file.
src/bp-templates/bp-nouveau/buddypress/common/js-templates/invites/index.php

Anchor tag closing is missing on this template.

[mercime]

@ankitmaru Good catch on the closing anchor tag. That error was my bad from #7752 where I missed replacing the closing button tag with a closing anchor tag. Attached 8184.patch to correct the issue.

[ankitmaru]

@mercime Thank you so much.

[imath]

Hi @ankitmaru

Thanks a lot for your feedback.

Hi @mercime thanks a lot for your patch. I have a few recommandations before you commit it to trunk. Could you :

• git checkout npm-shrinkwrap.json,
• Update the @version 3.1.0 docblock comment at the top of the src/bp-templates/bp-nouveau/buddypress/common/js-templates/invites/index.php file and use the version it will be committed for (@version 6.0.0) ?

Then, feel free to commit ;)

[mercime]

In 12513:

BPNouveau: Use correct closing tag for anchor element.

Fixes overlooked closing tag when I changed button
element to anchor tag for invites navigation, my bad.

Props ankitmaru, imath.
Fixes #8184.