Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

#8184 closed defect (bug) (fixed)

Coding Standard : Anchor Tag Closing missing - src/bp-templates/bp-nouveau/buddypress/common/js-templates/invites/index.php

Reported by: ankitmaru's profile ankitmaru Owned by: mercime's profile mercime
Milestone: 6.0.0 Priority: normal
Severity: normal Version: 3.0.0
Component: Templates Keywords: has-patch needs-refresh
Cc:

Description

Please check this file.
src/bp-templates/bp-nouveau/buddypress/common/js-templates/invites/index.php

Anchor tag closing is missing on this template.

Attachments (3)

anchor_tag_closing_missing.diff​ (928 bytes) - added by ankitmaru 5 years ago.
new_anchor_tag_closing_missing.diff​ (928 bytes) - added by ankitmaru 5 years ago.
8184.patch​ (1.1 KB) - added by mercime 5 years ago.

Download all attachments as: .zip

Change History (8)

@ankitmaru
5 years ago

@ankitmaru
5 years ago

@mercime
5 years ago

#1 @mercime
5 years ago

@ankitmaru Good catch on the closing anchor tag. That error was my bad from #7752 where I missed replacing the closing button tag with a closing anchor tag. Attached 8184.patch to correct the issue.

#2 @mercime
5 years ago

  • Component changed from Core to Templates

#3 @ankitmaru
5 years ago

@mercime Thank you so much.

Last edited 5 years ago by ankitmaru (previous) (diff)

#4 @imath
5 years ago

  • Keywords needs-refresh added
  • Milestone changed from Awaiting Review to 6.0.0
  • Version changed from 5.0.0 to 3.0.0

Hi @ankitmaru

Thanks a lot for your feedback.

Hi @mercime thanks a lot for your patch. I have a few recommandations before you commit it to trunk. Could you :

  • git checkout npm-shrinkwrap.json,
  • Update the @version 3.1.0 docblock comment at the top of the src/bp-templates/bp-nouveau/buddypress/common/js-templates/invites/index.php file and use the version it will be committed for (@version 6.0.0) ?

Then, feel free to commit ;)

#5 @mercime
5 years ago

  • Owner set to mercime
  • Resolution set to fixed
  • Status changed from new to closed

In 12513:

BPNouveau: Use correct closing tag for anchor element.

Fixes overlooked closing tag when I changed button
element to anchor tag for invites navigation, my bad.

Props ankitmaru, imath.
Fixes #8184.

Note: See TracTickets for help on using tickets.