RTL stylesheets must replace with regular ones, not extend them

[geminorum]

The old WordPress way of registering RTL styles is to extend default css with RTL diffs. But the RTLCSS npm package generates a full RTL version of styles and must replace with the default. So wp_style_add_data() will not work correctly since it enqueues both styles together.

[imath]

Hi @geminorum

Thanks a lot for your ticket and for your patch. Instead of defining a $rtl variable to eventually use the rtl version instead of the ltr, I think it can be achieved using 'replace' instead of true for the last argument of wp_style_add_data().

For instance :

wp_style_add_data( 'bp_activity_admin_css', 'rtl', 'replace' );

Could you check if it's the case and if so, update the patch accordingly ?

[geminorum]

with “replace” data key

[geminorum]

Hi @imath

thanks for the tip, the patch updated accordingly.

[imath]

In 12401:

When needed RTL versions of CSS used in Core now replace the LTR ones

Props geminorum

Fixes #8097