Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

#8065 closed defect (bug) (fixed)

BP Nouveau Activity Post Form markup should be more in line with BP Legacy's one

Reported by: imath's profile imath Owned by: imath's profile imath
Milestone: 5.0.0 Priority: normal
Severity: normal Version: 3.0.0
Component: Templates Keywords: has-patch
Cc:

Description

in BP Legacy action buttons are wrapped into #whats-new-options. In BP Nouveau, it's not the case and it looks like it's causing displaying issues for some developers using the 'bp_activity_post_form_options' hook.

I'm going to work on this to make things more similar from one template pack to another.

Attachments (1)

8065.patch​ (6.3 KB) - added by imath 6 years ago.

Download all attachments as: .zip

Change History (3)

@imath
6 years ago

#1 @imath
6 years ago

  • Keywords has-patch added; needs-patch removed

​8065.patch is making sure all action buttons (and the custom HTML injected using the bp_activity_post_form_options hook) is wrapped into the #whats-new-options container div just like in Legacy.

It also moves the custom HTML injected using the bp_before_activity_post_form hook inside the form tag, just like it's the case in Legacy.

#2 @imath
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 12358:

BP Nouveau: Improve Activity Post Form backcompat with legacy hooks

  • Make sure the bp_before_activity_post_form hook is fired inside the form tag.
  • Wrap action buttons and form options into the same container #whats-new-options.
  • Make sure the bp_activity_post_form_options is fired inside this container.

Fixes #8065

Note: See TracTickets for help on using tickets.