Nouveau bp_nouveau_ajax_object_template_loader(): Use bp_get_template_part()

[dcavins]

While adding Nouveau support to a plugin that interacts with BP's template stack and template selection filters, I found that the AJAX-requested template parts in Nouveau were not utilizing the bp_get_template_part filter. I think this was done so that the template path could be passed through a Nouveau-specific filter instead of just being built. Here's a small change that preserves the Nouveau filter while also using a slightly modified version of bp_get_template_part().

[dcavins]

Use bp_get_template_part() in Nouveau's AJAX template loader.

[espellcaste]

This can go into the next release.

[dcavins]

Replying to espellcaste:

This can go into the next release.

Thanks for taking a look, @espellcaste.

@imath, if you have a minute, could you take a look and make sure I'm not steamrolling the intent of the original code? Thanks!

[imath]

Hi @dcavins

Sure! To be honest, I can't remember why I've done so 😬. I will try to find why asap !

[dcavins]

Replying to imath:

Hi @dcavins

Sure! To be honest, I can't remember why I've done so 😬. I will try to find why asap !

Thanks!

[imath]

@dcavins

I found why I couldn't remember. Actually, I was using bp_get_template_part() 😀 see the last state of the file on the ​Next Template Packs repo

This part was edited in [11821] by @DJPaul. I'd ask him to be sure before committing the change ;)

[dcavins]

Ah! It looks like the point of that commit was to introduce a new filter, which couldn't have been done with the way bp_get_template_part() behaved at that time. We'll see if Paul has any memory beyond that.

Thanks again!

[espellcaste]

@DJPaul What do you think? Are we safe? =P

[imath]

Let's take more time to fix this.

[dcavins]

I think we can close this, since Nouveau has its own filter that accomplishes a similar result: $template_path = apply_filters( 'bp_nouveau_object_template_path', $template_path );