Skip to:

Opened 5 years ago

Closed 5 years ago

#8028 closed defect (bug) (fixed)

Javacript updates the Favourite/UnFavorite button incorrectly on Nouveau

Reported by: joncadams's profile joncadams Owned by: boonebgorges's profile boonebgorges
Milestone: 5.0.0 Priority: normal
Severity: normal Version: 3.0.0
Component: Templates Keywords:


I think I found a bug on Nouveau:
the javascript gives the button a title attribute it did not have initially after updating with ajax, and does not update the tooltip as it should. to keep things consistent I made the following changes:

In bp-nouveau\js\buddypress-activity.js on line 464:

$( this ).prop( 'title', );

should be:

$( this ).attr( 'data-bp-tooltip', );

In bp-nouveau\includes\activity\ajax.php on line 145:

$response = array( 'content' => __( 'Favorite', 'buddypress' ) );

should be:

$response = array( 'content' => __( 'Mark as Favorite', 'buddypress' ) );

And in bp-nouveau\includes\activity\template-tags.php on line 378:

'link_text'        => __( 'Favorite', 'buddypress' ),

should be:

'link_text'        => __( 'Mark as Favorite', 'buddypress' ),

Change History (2)

#1 @boonebgorges
5 years ago

  • Milestone changed from Awaiting Review to 5.0.0
  • Version changed from 4.1.0 to 3.0.0

Good catch, and good fix! Thank you.

#2 @boonebgorges
5 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 12348:

Nouveau: Update Favorite button tooltip after AJAX action.

Props joncadams.
Fixes #8028.

Note: See TracTickets for help on using tickets.