Friendship Requested button on member's profile doesn't respond anything

[Ankit K Gupta]

Use Case Scenario: when member gets friendship request from another member and try to accept. He/She can not.
Previously this button redirects to All request page i.e. '/friends/requests/' but in BP 3.0 <a> has been removed due to any reason.

To be more specific, please watch these links:

With BP RC 3.0: ​https://screencast-o-matic.com/watch/cFho1cbaUW
With BP 2.9.4: ​https://screencast-o-matic.com/watch/cFho11bavI

[Ankit K Gupta]

screenshot of member profile

[imath]

Hi @Ankit K Gupta

I confirm. Nice catch. Thanks a lot for your feedback about it. FYI That's specific to the Nouveau template. If you switch back to the Legacy template you should get the right behavior for this button. That's why i changed the Component to templates.

7831.patch is a first patch that should fix the issue. But I need to carry on investigating about it to see if the patch can be improved.

[imath]

@hugo checking this ​https://github.com/buddypress/next-template-packs/commit/d223aec30cc1bf92f0d7218b5ef9382e1b4edfd6#diff-8a859e585ba96d39d84477b7703a0dfe It looks like the button element is a layout choice. So I guess the 7831.patch is the best way to fix it without changing too many things.

[DJPaul]

I’m happy to accept the current version of the patch into 3.0, once it’s OK’d by another core team member.

[imath]

Thanks for your feedback @DJPaul I totally agree I’d feel safer with @hnla ‘s opinion on it 😊

[hnla]

@imath having a quick look.

[hnla]

@imath yep agree on patch, the element was part of the somewhat tricky markup switching between button element and anchors where appropriate and providing additionally as user option, proved a burden to try and get right in the end. Testing the patch and scanning the function and it all seems good, expected behaviour is returned and function logic looks correct, I would commit the patch.

@Ankit K Gupta Nice catch thanks for spotting and reporting.

[imath]

In 12092:

BP Nouveau: use a link for the awaiting response friendship button.

This makes sure the logged in user can view and reply to his friendship requests.

Props ankit-k-gupta, DJPaul, hnla

Fixes #7831

[Ankit K Gupta]

Hello @imath @hnla,

Thank you for your kind words it means a lot to me! :)