BP Nouveau: Group activity buttons actions are not working when set options to customizer

[dunhakdis]

No plugins installed aside from BuddyPress itself (BuddyPress 3.0 Beta2), using the theme TwentySixteen

Scenario:

1: Go to wp-admin > appearance > customizer > buddypress nouveau > group front page > enable custom front pages for groups (unchecked)

Will return the following (screenshot below):

2: Go to wp-admin > appearance > customizer > buddypress nouveau > group front page > enable custom front pages for groups (checked)

• Activity link in nav appears and actions is now properly working. Home link in nav is set to custom:

---

Thanks!

[dunhakdis]

A better solution is recommended. Thanks!

[imath]

Hi @dunhakdis

Nice catch, i confirm the issue ! Thanks a lot for the patch, i think we can improve it a bit :)

If you look into src/bp-core/bp-core-template.php you'll find some conditional tags eg: bp_is_group() is checking the loaded page belongs to a Group. The conditional tag bp_is_group_activity() should be a nice replacement to the if statement you edited at line 241 ('groups' === bp_current_component() && in_array( bp_current_action(), $activity_actions_in_groups ) ))

Then we can save the 2 lines of code you added to define $activity_actions_in_groups.

Can you update the patch this way ?

[dunhakdis]

Cool! I completely forget about bp_is_group_activity(). I also think that we can completely omit the'groups' === bp_current_component() condition since bp_is_group_activity() is already checking whether the current component belongs to 'groups' via bp_is_groups_components()

I'll attach a new diff file shortly. Thanks!

[dunhakdis]

New patch file. Cheers

[imath]

Great! Thanks a lot for the update. Let's have it in!

[imath]

In 12075:

BP Nouveau - Customizer: improve Group activity stream preview.

Single Group Activity stream was missing a class when the Group front page Customizer setting was disabled. In this particular case, the Group home page is the Group Activity stream page. The class was not added because the current action is not "activity" but "home". Using the bp_is_group_activity() conditional tag solves the issue.

Props dunhakdis

Fixes #7813