Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

#7810 closed defect (bug) (fixed)

Missing label of "Template Pack" on BP settings page

Reported by: ankit-k-gupta's profile Ankit K Gupta Owned by: mercime's profile mercime
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Settings Keywords: has-patch
Cc: ankitgupta.sqa@…

Description

Currently, we are using label for description <p> tag and removed from "Template Pack" title.
And on other pages, we are using label on each title.
Would be great if show same behavior on all select box.

Attachments (3)

patch.diff​ (1.6 KB) - added by Ankit K Gupta 6 years ago.
added patch file
Screenshot of BuddyPress Options ‹ forCore — WordPress.jpg​ (45.6 KB) - added by Ankit K Gupta 6 years ago.
Screenshot after Fix
7810.2.patch​ (2.7 KB) - added by mercime 6 years ago.

Download all attachments as: .zip

Change History (7)

@Ankit K Gupta
6 years ago

added patch file

@Ankit K Gupta
6 years ago

Screenshot after Fix

#1 @Ankit K Gupta
6 years ago

  • Keywords has-patch added

#2 @boonebgorges
6 years ago

  • Milestone changed from Awaiting Review to 3.0

Thank you for the patch @Ankit K Gupta !

This does seem more semantic, and as you note, it's what we do on the Pages tab. @mercime, could you please review to make sure that this change is proper?

@mercime
6 years ago

#3 @mercime
6 years ago

+100 @ankit-k-gupta! Thanks for the patch :)

@boonebgorges Confirmed. Also took this opportunity via 7810.2.patch​ to associate a couple of form controls with their descriptions via aria-describedby attr. This way, assistive technologies will also announce the descriptions of respective form controls when in Forms Mode while tabbing through the options.

#4 @mercime
6 years ago

  • Owner set to mercime
  • Resolution set to fixed
  • Status changed from new to closed

In 12056:

Administration: Fix accessibility of Template Pack selection.

Props ankit-k-gupta, boonebgorges.
Fixes #7810.

Note: See TracTickets for help on using tickets.