Skip to:
Content

BuddyPress.org

#7753 closed defect (bug) (fixed)

BP Nouveau: Group > Create > Group Invites <li> elements must be contained in a <ul> or <ol>.

Reported by: mercime Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-screenshots has-patch
Cc:

Description

Following #7752, checked Group Invites screen and found the same issue with ungrouped <li> elements.

<div class="item-body" id="group-create-body">
	<nav class="bp-navs group-create-links no-ajax tabbed-links" id="group-create-tabs" role="navigation" aria-label="Group creation menu">
	... etc ...
	</nav>

	// Missing UL wrapper
	<li><label for="f-62"><input type="checkbox" name="friends[]" id="f-62" value="62"> Mamah Cheney</label></li>
	<li><label for="f-48"><input type="checkbox" name="friends[]" id="f-48" value="48"> Matraca Berg</label></li>
	<li><label for="f-52"><input type="checkbox" name="friends[]" id="f-52" value="52"> Picabo Street</label></li>
	<li><label for="f-54"><input type="checkbox" name="friends[]" id="f-54" value="54"> Seamus</label></li>
	<li><label for="f-56"><input type="checkbox" name="friends[]" id="f-56" value="56"> Siobhan</label></li>

	<input type="hidden" id="_wpnonce" name="_wpnonce" value="ca80ce7abf">
	<input type="hidden" name="_wp_http_referer" value="/codex/groups/create/step/group-invites/">
	<input type="hidden" name="group-id" id="group-id" value="96">
	<div class="submit" id="previous-next">
		<input type="button" value="Back to Previous Step" id="group-creation-previous" name="previous" onclick="location.href='http://localhost/codex/groups/create/step/group-cover-image/'">
		<input type="submit" value="Finish" id="group-creation-finish" name="save">
	</div>
</div>

Attachments (2)

group-create-invitation.png (20.1 KB) - added by mercime 14 months ago.
P.S. Needs styling as well
7753-ul-style.patch (1.2 KB) - added by mercime 14 months ago.

Download all attachments as: .zip

Change History (15)

#1 @mercime
14 months ago

  • Milestone changed from Awaiting Review to 3.0

@mercime
14 months ago

P.S. Needs styling as well

#2 @mercime
14 months ago

  • Keywords has-screenshots added

#3 @hnla
14 months ago

@mercime could you check bp-nouveau/buddypress/groups/create-invites.php

Have you got:
bp_new_group_invite_friend_list( array( 'before' => '<ul class="friends-list create-group-invites">', 'after' => '</ul>' ) );

In fact I ought to check my commits... and low it's staged for commit seems I overlooked it, my bad, but makes me wonder if atts are the best approach here but will commit regardless but leave this ticket open for the moment.

#4 @hnla
14 months ago

In 11984:

Commit create-invites.php template for updated function atts ( html )

Template missed from original commits.

See #7753

#5 @mercime
14 months ago

  • Keywords has-patch added

@hnla when you have the time, please check this patch where I removed list styles from ul.friend-list

#6 follow-up: @hnla
14 months ago

Yep go for it, They don't look right, although looking at things we have a little confusion as main groups invite members list is a members-list/bp-list in terms of classes and why list styles are removed there, so maybe the better/easier approach is adding .bp-list to the create invites list, so we inherit the styles set gnerically for bp-lists?

#7 in reply to: ↑ 6 @mercime
14 months ago

Replying to hnla:

Yep go for it, They don't look right, although looking at things we have a little confusion as main groups invite members list is a members-list/bp-list in terms of classes and why list styles are removed there, so maybe the better/easier approach is adding .bp-list to the create invites list, so we inherit the styles set gnerically for bp-lists?

Thanks @hnla. Going to commit 7753-ul-style.patch since bp-list includes border-top: 1px solid #eaeaea; which imho doesn't look good on this screen.
https://cldup.com/k0EhvwqZIZ.png

#8 @mercime
14 months ago

In 11990:

Nouveau: Remove list style for Group Invite Friends list.

See #7753.

#9 @hnla
14 months ago

Fair enough.

#10 @DJPaul
14 months ago

Is this done now? @mercime

#11 @mercime
14 months ago

... makes me wonder if atts are the best approach here but will commit regardless but leave this ticket open for the moment.

@hnla do you still want to keep this ticket open or do you want to close this ticket and create a new one for alternative approach?

#12 @hnla
14 months ago

@mercime lets close, and go with current approach, think we want to avoid creating new work unless it's bug fixing?

#13 @mercime
14 months ago

  • Resolution set to fixed
  • Status changed from new to closed

@hnla as you wish. Closing this ticket as fixed.

Note: See TracTickets for help on using tickets.