Skip to:
Content

BuddyPress.org

Opened 18 months ago

Closed 18 months ago

Last modified 3 months ago

#7733 closed defect (bug) (fixed)

Update `.editorconfig` to match WordPress'

Reported by: netweb Owned by: netweb
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords:
Cc:

Description

WordPress has updated .editorconfig file in https://core.trac.wordpress.org/changeset/42862/

Note: As part of this .jshintrc and *.json files now support tabbed indentation and will also be updated as part of this change

Attachments (1)

7733.diff (384 bytes) - added by netweb 18 months ago.

Download all attachments as: .zip

Change History (6)

@netweb
18 months ago

#1 @DJPaul
18 months ago

This is a low-value change overall, but if the code standards for indentation has changed in the JS files, please re-save them and commit the changes as well.

#2 @djpaul
18 months ago

  • Resolution set to fixed
  • Status changed from new to closed

In 11945:

Build: instruct file editors not to trim trailing whitespace in Markdown files.

Two trailing spaces in a markdown file indicates a line break.

BuddyPress does not contain Markdown files but this changes brings us inline with WordPress,
where historically we've matched code standards.

See #WP43104

Fixes #7733

Props netweb

#3 @djpaul
18 months ago

In 11946:

Build: instruct file editors to use tabs for indentation for .jshintrc and *.js files.

This changes brings us inline with WordPress, where historically we've matched code standards.

See #WP43075

Fixes #7733

Props netweb

#4 @DJPaul
18 months ago

We had no files that needed changing. Thanks for the patch @netweb :)

#5 @netweb
18 months ago

In 11947:

Build: Use tabs for indentaion, follow up to [11946]

See #7733.

Note: See TracTickets for help on using tickets.