Skip to:
Content

BuddyPress.org

#7721 closed enhancement (fixed)

Finalize All Member Notices admin screen

Reported by: mercime Owned by: mercime
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch has-screenshots commit
Cc:

Description

  1. Current screen has an "Add New Notice" that's an empty link and the New Notice Form is already visible on screen above the table with the list of Notices. Question is, shall we remove the "Add New Notice" empty link and make it the heading for the New Notice Form or was there a plan to make another admin screen with the "Add New Notice" link?
  2. Close Form tag needs.
  3. Replace table markup of the New Notice form.

Patch coming up for issues 2 & 3 along with before and after screenshots.

Attachments (5)

7721.patch (8.4 KB) - added by mercime 18 months ago.
all-member-noticesafter.png (40.1 KB) - added by mercime 18 months ago.
7722-v1.patch (10.2 KB) - added by mercime 18 months ago.
7722-v2.patch (10.2 KB) - added by mercime 18 months ago.
site-notices.png (35.9 KB) - added by mercime 18 months ago.

Download all attachments as: .zip

Change History (14)

@mercime
18 months ago

#1 @mercime
18 months ago

  • Keywords has-patch has-screenshots added

#2 @mercime
18 months ago

  • Milestone changed from Awaiting Review to 3.0

#3 @dcavins
18 months ago

Did I break this when I moved it out of Nouveau, or are these further improvements that you're making to what exists? Either way, I'm in favor, and please let me know if you need assistance or testing or whatever. :)

#4 @mercime
18 months ago

  • Type changed from defect (bug) to enhancement

Thanks @dcavins! I'll take you up on that offer of course. Great idea by the way to move the All Messages admin to core :D

The empty link and table layout were there before Nouveau merge. Left it alone at that time because I thought there was going to be some other elements to be added on before BP 3.0 rolls out.

Since we're close to the finish line for this dev cycle, it would great to get feedback for the final set up of this screen. If there's nothing else that's going to be added/removed, I propose we have the following structure:

<h1> - All Member Notices
( - ) delete Add New Notice empty link
( + ) <p>Manage all site-wide notices</p> etc
( + ) <h2> - Add New Notice
bp-panel - New notice form
( + ) <h2> - Notices List
<table>
( + ) table <caption> Set up column visibility at the Screen Options panel above.</caption>

For review/comments. Thanks.

Last edited 18 months ago by mercime (previous) (diff)

#5 @DJPaul
18 months ago

Your comments are good @mercime and the improvements even better!

I don't think we need the "cancel notice" button -- seems unnecessary.
Would also suggest renaming "Save notice" to "Publish notice" to better match terminology on WP-Admin/Edit Post -- to hopefully hint that it goes live immediately, vs. saving a draft.

Let's rename the actual page / menu item away from "All Member Notices". I was going to do this anyway, we might as well group it with this change:

  • We would need to use "Users" not "Members" to fit in with all the other WordPress menu items in this section.
  • But, perhaps "Site Notices" is adequate.

?

Last edited 18 months ago by DJPaul (previous) (diff)

@mercime
18 months ago

@mercime
18 months ago

#6 @mercime
18 months ago

Thanks @djpaul :D Attached are 2 patches and a screenshot showing two versions for comments/review.

#7 @DJPaul
18 months ago

  • Keywords commit added

Looks fine!

#8 @mercime
18 months ago

  • Owner changed from slaFFik to mercime
  • Status changed from new to assigned

#9 @mercime
18 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 11910:

Finalize the new Site Notices admin screen.

Props mercime, djpaul.
Fixes #7721.

Note: See TracTickets for help on using tickets.