Skip to:

Opened 6 years ago

Closed 6 years ago

#7712 closed defect (bug) (fixed)

BP-Nouveau: Fix Invite/Uninvite status in tooltips/info for Group Send Invites screen

Reported by: mercime's profile mercime Owned by: mercime's profile mercime
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-screenshots has-patch


This was mentioned before in the Next Template Pack github repo and I did not find any ticket for this issue in BP Trac, so bringing this up now before the new template pack ships with BP 3.0

Attaching screenshot in a minute for reference.

Attachments (3)

invite-uninvite.jpg (23.0 KB) - added by mercime 6 years ago.
7712.patch (1.8 KB) - added by mercime 6 years ago.
7712.2.patch (3.4 KB) - added by imath 6 years ago.

Download all attachments as: .zip

Change History (11)

#1 @mercime
6 years ago

  • Keywords has-screenshots added

#2 @DJPaul
6 years ago

  • Milestone changed from Awaiting Review to 3.0

#3 @DJPaul
6 years ago

@mercime What's the actual issue? Is it the actual text on this element, or something else?

#4 @DJPaul
6 years ago

  • Milestone changed from 3.0 to Under Consideration

6 years ago

#5 @mercime
6 years ago

  • Keywords has-patch added
  • Milestone changed from Under Consideration to 3.0

@DJPaul Sorry I missed this. 7712.patch is first pass at changing "Invite / Uninvite" text on tooltip and screen reader text. Need your help @imath, JS not working on change :( Edit - would you like to handle it here or at #7794 Backbone Views?

Last edited 6 years ago by mercime (previous) (diff)

6 years ago

#6 @imath
6 years ago

@mercime 7712.2.patch should fix the JS, let's handle it here, no problem ;)

#7 @mercime
6 years ago

Merci beaucoup @imath! Committing in a few minutes.

#8 @mercime
6 years ago

  • Owner set to mercime
  • Resolution set to fixed
  • Status changed from new to closed

In 12057:

Nouveau: Fix the status of a group invitation for screen reader text and tooltip.

Improve Backbone Invites template to make sure that the text for screen readers
& tooltips shows the current state of group invitation for site members.

Props imath.
Fixes #7712.

Note: See TracTickets for help on using tickets.