Skip to:
Content

BuddyPress.org

Opened 3 years ago

Closed 3 years ago

#7649 closed defect (bug) (fixed)

Error: extra quotation mark and a right-arrow symbol in buddypress\bp-messages\bp-messages-template.php line 1340

Reported by: uzosky Owned by:
Milestone: 2.9.2 Priority: high
Severity: major Version: 2.9.2
Component: Messages Keywords: has-patch
Cc:

Description

Their is an extra quotation mark and a right-arrow symbol in buddypress\bp-messages\bp-messages-template.php line 1340.
Just after: <?php esc_attr_e( 'Dismiss this notice', 'buddypress' ) ?>

http://www.diy9.org/temp-img/site-wide-notice-error.png

Attachments (1)

7649.patch (1.1 KB) - added by hnla 3 years ago.
Remove incorrect additional closing angle bracket & quote mark on screen reader markup span element.

Download all attachments as: .zip

Change History (7)

@hnla
3 years ago

Remove incorrect additional closing angle bracket & quote mark on screen reader markup span element.

#1 @hnla
3 years ago

  • Component changed from Core to Messages
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 2.9.2
  • Priority changed from highest to high
  • Severity changed from critical to major

@uzosky Thanks, good spot. Clearly slipped through unnoticed as it's in the hidden screen reader text.

#2 @hnla
3 years ago

I guess we ought to commit this to the 2.9 branch?

#3 @DJPaul
3 years ago

Please do

#4 @hnla
3 years ago

In 11777:

Correct stray HTML characters in template notice button string

Commit removes stray HTML characters from being rendered in output string for the sitewide notice close button screen reader 'span' introduced in r11582.

See #7649

Props @uzosky

#5 @hnla
3 years ago

In 11778:

Correct stray HTML characters in template notice button string

Commit removes stray HTML characters from being rendered in output string for the sitewide notice close button screen reader 'span' introduced in r11582.

Merge r11777 to 2.9 branch.

See #7649

Props @uzosky

#6 @hnla
3 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.