Skip to:
Content

BuddyPress.org

#7606 closed defect (bug) (fixed)

RTL Support for Emails

Reported by: vapvarun Owned by: DJPaul
Milestone: 3.0 Priority: normal
Severity: normal Version: 2.5.0
Component: Emails Keywords: needs-patch
Cc: stephen@…

Description

For RTL sites, There is no option to move footer and header to the right side. Also in email body when we put a period at the end of the persian sentence the period come to the first of the line.

text-align: left is also hardcoded inside
/buddypress/bp-templates/bp-legacy/buddypress/assets/emails/single-bp-email.php
Line 188

<td style="padding: 20px; width: 100%; font-size: <?php echo esc_attr( $settings['footer_text_size'] . 'px' ); ?>; font-family: sans-serif; mso-height-rule: exactly; line-height: <?php echo esc_attr( floor( $settings['footer_text_size'] * 1.618 ) . 'px' ) ?>; text-align: left; color: <?php echo esc_attr( $settings['footer_text_color'] ); ?>;" class="footer_text_color footer_text_size">

Attachments (3)

Capture3.JPG (66.2 KB) - added by vapvarun 21 months ago.
No options to align header & footer for RTL
Capture4.JPG (69.9 KB) - added by vapvarun 21 months ago.
Period inside the mail content stick toward right
Capture5.JPG (40.6 KB) - added by vapvarun 21 months ago.
attached in support of capture4.jpg

Download all attachments as: .zip

Change History (6)

@vapvarun
21 months ago

No options to align header & footer for RTL

@vapvarun
21 months ago

Period inside the mail content stick toward right

@vapvarun
21 months ago

attached in support of capture4.jpg

#1 @DJPaul
21 months ago

  • Component changed from Core to Emails
  • Milestone changed from Awaiting Review to 3.0
  • Owner set to DJPaul
  • Version changed from 2.8.2 to 2.5.0

@vapvarun Thanks for reporting this issue. I am sorry I forgot about RTL languages when writing the email template, it was my mistake.

Because email HTML has to be in-line, we need to duplicate the template and make sure the new filename is supported in the template stack.

Given the mix of PHP, HTML, and CSS, in the email template, we probably can't automate this via Grunt unless we somehow split the HTML/CSS out into separate files.

#2 @netweb
21 months ago

  • Cc stephen@… added

#3 @djpaul
18 months ago

  • Resolution set to fixed
  • Status changed from new to closed

In 11786:

Emails: RTL support.

Fixes #7606

Note: See TracTickets for help on using tickets.