Skip to:
Content

BuddyPress.org

Opened 9 years ago

Closed 9 years ago

#7600 closed enhancement (fixed)

Add before/after delete filters to BP_XProfile_Field

Reported by: mechter Owned by: djpaul
Priority: normal Milestone: 3.0
Component: Extended Profile Version: 2.9.0
Severity: normal Keywords:
Cc: lmoffereins@…

Description

BP_XProfile_Group and BP_XProfile_ProfileData both have them, but they seem to have been omitted for BP_XProfile_Field.

Attachments (1)

7600.patch​ (1.1 KB ) - added by mechter 9 years ago.

Download all attachments as: .zip

Change History (6)

@mechter
9 years ago

#1 @mechter
9 years ago

  • Keywords has-patch added

#2 @djpaul
9 years ago

  • Owner set to djpaul
  • Resolution → fixed
  • Status new → closed

In 11700:

xprofile: add before/after actions around when a BP_XProfile_Field instance gets deleted (the data, not the object).

For consistency with BP_XProfile_Group and BP_XProfile_ProfileData.

Fixes #7600

Props mechter

#3 @DJPaul
9 years ago

Thanks again for another perfect patch. A good way to start the day!

#4 @Offereins
9 years ago

  • Cc lmoffereins@… added
  • Keywords has-patch removed
  • Resolution fixed
  • Status closed → reopened

In the hooks I'm missing the $delete_data parameter which is provided to the delete method. Can we add this as a second (or first?) parameter so we know the proper context of the field's deletion?

#5 @DJPaul
9 years ago

  • Resolution → fixed
  • Status reopened → closed

Sure, but in a new ticket, please.

Note: See TracTickets for help on using tickets.