duplicated paramater

[idofri]

The requesting user id is being passed twice to the 'groups_membership_requested' action-hook in bp-groups-functions.php @ line 1824:

<?php
do_action( 'groups_membership_requested', $requesting_user_id, $admins, $group_id, $requesting_user->id );

FYI.

[DJPaul]

Hi @idofri
Thanks for reaching out.

I took a look and despite the inline documentation, that last parameter ($requesting_user->id ) is a BP_Groups_Member object, whose id property is the unique ID of the group membership in the database (its primary key). I'll go update the docs now.

[djpaul]

In 11671:

Groups: fix documentation for groups_membership_requested action.

Fixes #7581

Props idofri

[idofri]

Replying to DJPaul:

Hi @idofri
Thanks for reaching out.

I took a look and despite the inline documentation, that last parameter ($requesting_user->id ) is a BP_Groups_Member object, whose id property is the unique ID of the group membership in the database (its primary key). I'll go update the docs now.