Skip to:
Content

Opened 12 months ago

Closed 5 months ago

Last modified 5 months ago

#7552 closed enhancement (invalid)

Introduce 'visibility' parameter for registering BP nav items

Reported by: r-a-y Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Navigation Keywords:
Cc:

Description

Split from #7349, the following patch introduces a new 'visibility' parameter in bp_core_new_nav_item().

If set to false, this allows for a nav item to be hidden, but the screen function to still be registered.

More details can be found from this comment and on:
https://buddypress.trac.wordpress.org/ticket/7349#comment:13

Attachments (1)

7552.01.patch (2.1 KB) - added by r-a-y 12 months ago.

Download all attachments as: .zip

Change History (7)

@r-a-y
12 months ago

#1 @DJPaul
11 months ago

  • Component changed from Core to Navigation
  • Milestone changed from Under Consideration to 3.0

I like the principle, let's take a look.

#2 @DJPaul
11 months ago

  • Keywords needs-patch added; has-patch dev-feedback removed
  • Milestone changed from 3.0 to Future Release

I don't believe we can remove the show_for_displayed_user parameter.

#3 follow-up: @r-a-y
11 months ago

Have you tested the patch? It works.

Do the following:

  • Make sure you are logged out.
  • Navigate to any user's Messages page (example.com/members/user/messages/)
  • With the patch, you get redirected to login. Without the patch, you get 404'd.
Last edited 11 months ago by r-a-y (previous) (diff)

#4 in reply to: ↑ 3 @r-a-y
5 months ago

  • Keywords needs-patch removed
  • Milestone Awaiting Contributions deleted

Replying to r-a-y:

Have you tested the patch? It works.

Do the following:

  • Make sure you are logged out.
  • Navigate to any user's Messages page (example.com/members/user/messages/)
  • With the patch, you get redirected to login. Without the patch, you get 404'd.

#7659 properly notes the bug that is causing this problem.

Closing as a duplicate.

#5 @r-a-y
5 months ago

  • Resolution set to invalid
  • Status changed from new to closed

This ticket was mentioned in Slack in #buddypress by r-a-y. View the logs.


5 months ago

Note: See TracTickets for help on using tickets.