Skip to:
Content

BuddyPress.org

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#7552 closed enhancement (no action required)

Introduce 'visibility' parameter for registering BP nav items

Reported by: r-a-y's profile r-a-y Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Navigation Keywords:
Cc:

Description

Split from #7349, the following patch introduces a new 'visibility' parameter in bp_core_new_nav_item().

If set to false, this allows for a nav item to be hidden, but the screen function to still be registered.

More details can be found from this comment and on:
​https://buddypress.trac.wordpress.org/ticket/7349#comment:13

Attachments (1)

7552.01.patch​ (2.1 KB) - added by r-a-y 7 years ago.

Download all attachments as: .zip

Change History (7)

@r-a-y
7 years ago

#1 @DJPaul
7 years ago

  • Component changed from Core to Navigation
  • Milestone changed from Under Consideration to 3.0

I like the principle, let's take a look.

#2 @DJPaul
7 years ago

  • Keywords needs-patch added; has-patch dev-feedback removed
  • Milestone changed from 3.0 to Future Release

I don't believe we can remove the show_for_displayed_user parameter.

#3 follow-up: @r-a-y
7 years ago

Have you tested the patch? It works.

Do the following:

  • Make sure you are logged out.
  • Navigate to any user's Messages page (example.com/members/user/messages/)
  • With the patch, you get redirected to login. Without the patch, you get 404'd.
Last edited 7 years ago by r-a-y (previous) (diff)

#4 in reply to: ↑ 3 @r-a-y
7 years ago

  • Keywords needs-patch removed
  • Milestone Awaiting Contributions deleted

Replying to r-a-y:

Have you tested the patch? It works.

Do the following:

  • Make sure you are logged out.
  • Navigate to any user's Messages page (example.com/members/user/messages/)
  • With the patch, you get redirected to login. Without the patch, you get 404'd.

#7659 properly notes the bug that is causing this problem.

Closing as a duplicate.

#5 @r-a-y
7 years ago

  • Resolution set to invalid
  • Status changed from new to closed

This ticket was mentioned in ​Slack in #buddypress by r-a-y. ​View the logs.
7 years ago

Note: See TracTickets for help on using tickets.