Skip to:
Content

Opened 4 months ago

Last modified 3 months ago

#7536 reviewing enhancement

Use bp_get_admin_url() in XProfile instead of hard-coded links

Reported by: JohnPBloch Owned by: johnjamesjacoby
Milestone: 3.0 Priority: normal
Severity: normal Version: 1.2
Component: Extended Profile Keywords: needs-testing
Cc:

Description

There were several areas in XProfile that used hard-coded URLs instead of the BuddyPress helper function. Replacing hard-coded addresses with addresses generated by the BP helper will improve overall stability and add flexibility to the plugin overall.

Attachments (1)

7536.1.patch (7.0 KB) - added by JohnPBloch 4 months ago.

Download all attachments as: .zip

Change History (5)

@JohnPBloch
4 months ago

#1 @johnjamesjacoby
4 months ago

  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to 2.9
  • Owner set to johnjamesjacoby
  • Status changed from new to reviewing
  • Version set to 1.2

I'll test this out in the multitude of environment setups that we support.

I think relying on bp_get_admin_url() is OK, but there may be weirdness with single-site activations on multisite setups, where site-admins wouldn't normally have the option to edit user settings.

This ticket was mentioned in Slack in #buddypress by hnla. View the logs.


4 months ago

#3 @hnla
3 months ago

@johnjamesjacoby does the patch still need testing or do you want to squeeze it in or punt to 3.0?

#4 @hnla
3 months ago

  • Milestone changed from 2.9 to 3.0
Note: See TracTickets for help on using tickets.