Counter for "All" tab for activity and groups table

[bhargavbhandari90]

Currently there is no counter for "All" tab into activity and groups tables.
Is there any specific reason for that?

Because posts, pages, comments and users tables are showing counter for "All" tab.

[bhargavbhandari90]

It should be like this.

[bhargavbhandari90]

We should add the counter for consistency

[bhargavbhandari90]

Used existing string. So it will not effect on existing translation.

[hnla]

@bhargavbhandari90 I'm changing this back to _Awaiting Review_ , we'll try & review, hopefully today in the dev chat, and add it to the milestone.

[bhargavbhandari90]

@hnla Thank you. Let me know when you do dev chat. I would like to take part into this.

[hnla]

BuddyPress slack channel @ 19:00hrs UTC

[DJPaul]

I suspect it was because the number wasn't convenient in the database queries we are making to build that page.

Your patch has the problem of the query not being cached, of hardcoding the table name (I think we have this as a property on the main class for each Component, e.g. bp()->activity), and because this is not using the existing Activity API.

The last point is not a strict rule, but it's something we like. So, if you can't find the same total number in the activities global object somewhere, then you'd need to add caching around the query, and double-check that we don't hard-code the query name elsewhere (I might be remembering wrong).

[bhargavbhandari90]

@DJPaul

I got your point for the table name. And also my previous query may effect on DB performance for big database.

Now I am thinking like WP's count method of all post. We can do something like this : ​https://github.com/WordPress/WordPress/blob/master/wp-includes/post.php?utf8=%E2%9C%93#L2202

[DJPaul]

Hi!

if you can't find the same total number in the activities global object somewhere,

Did you look at these? BP_Activity_Template has a total_activity_count property which sounds helpful. Are we using the activities template loop for the activities wp-admin screen?

[bhargavbhandari90]

Replying to DJPaul:

Hi!

if you can't find the same total number in the activities global object somewhere,

Did you look at these? BP_Activity_Template has a total_activity_count property which sounds helpful. Are we using the activities template loop for the activities wp-admin screen?

I have to check this. Thanks for the info. @DJPaul

[DJPaul]

Did you get anywhere with this @bhargavbhandari90 ?

[bhargavbhandari90]

Used total_activity_count

[bhargavbhandari90]

Replying to DJPaul:

Did you get anywhere with this @bhargavbhandari90 ?

Hi @DJPaul

After almost 2 years, I saw this :). Yes you were right. We can use total_activity_count property. Thanks.

[bhargavbhandari90]

For group counter

[imath]

Thanks a lot for your patches @bhargavbhandari90 we're too close to 5.0.0 release, but let's try to include your improvements during the next development cycle.

[bhargavbhandari90]

Replying to imath:

Thanks a lot for your patches @bhargavbhandari90 we're too close to 5.0.0 release, but let's try to include your improvements during the next development cycle.

Sure.

[imath]

Move the first tickets to next major release.

[imath]

@bhargavbhandari90 could you review/test ​7526.2.patch ?

I've suggested some improvements in it like avoiding querying database if we don't need to.

Thanks in advance for your help. If that's ok for you I'll commit it asap.

[bhargavbhandari90]

Hi @imath,

Thanks for the patch. I've tested and it's working as expected.

Sorry for the late response.

[imath]

In 12551:

Add the total items amount in Activity and Groups Admin List Tables

The "All" view of the corresponding administration screens is now including the total amount of items between parenthesis.

Props bhargavbhandari90, DJPaul, Hnla

Fixes #7526