Skip to:
Content

Opened 6 months ago

Last modified 4 months ago

#7526 new enhancement

Counter for "All" tab for activity and groups table

Reported by: bhargavbhandari90 Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 2.8.2
Component: Activity Keywords: has-screenshots needs-patch
Cc: Groups, bn.bhandari90@…

Description

Currently there is no counter for "All" tab into activity and groups tables.
Is there any specific reason for that?

Because posts, pages, comments and users tables are showing counter for "All" tab.

Attachments (4)

alltabwithoutcounter.png (9.3 KB) - added by bhargavbhandari90 6 months ago.
activity-counter.png (9.4 KB) - added by bhargavbhandari90 6 months ago.
It should be like this.
7526.patch (3.8 KB) - added by bhargavbhandari90 6 months ago.
We should add the counter for consistency
7526-2.patch (3.8 KB) - added by bhargavbhandari90 6 months ago.
Used existing string. So it will not effect on existing translation.

Download all attachments as: .zip

Change History (12)

@bhargavbhandari90
6 months ago

It should be like this.

@bhargavbhandari90
6 months ago

We should add the counter for consistency

@bhargavbhandari90
6 months ago

Used existing string. So it will not effect on existing translation.

#1 @bhargavbhandari90
6 months ago

  • Keywords has-patch has-screenshots added

#2 @bhargavbhandari90
6 months ago

  • Cc bn.bhandari90@… added

#3 @bhargavbhandari90
6 months ago

  • Milestone changed from Awaiting Review to 2.9

#4 @hnla
6 months ago

  • Milestone changed from 2.9 to Awaiting Review

@bhargavbhandari90 I'm changing this back to _Awaiting Review_ , we'll try & review, hopefully today in the dev chat, and add it to the milestone.

#5 @bhargavbhandari90
6 months ago

@hnla Thank you. Let me know when you do dev chat. I would like to take part into this.

#6 @hnla
6 months ago

BuddyPress slack channel @ 19:00hrs UTC

Last edited 6 months ago by hnla (previous) (diff)

This ticket was mentioned in Slack in #buddypress by hnla. View the logs.


6 months ago

#8 @DJPaul
4 months ago

  • Keywords needs-patch added; dev-feedback has-patch removed
  • Milestone changed from Awaiting Review to Future Release

I suspect it was because the number wasn't convenient in the database queries we are making to build that page.

Your patch has the problem of the query not being cached, of hardcoding the table name (I think we have this as a property on the main class for each Component, e.g. bp()->activity), and because this is not using the existing Activity API.

The last point is not a strict rule, but it's something we like. So, if you can't find the same total number in the activities global object somewhere, then you'd need to add caching around the query, and double-check that we don't hard-code the query name elsewhere (I might be remembering wrong).

Note: See TracTickets for help on using tickets.