bp_member_profile_data( 'field=Non existing fields' )

[seventhqueen]

Hi, if you want to output a field that doesn't exist or the user hasn't yet completed you will get a PHP notice:
Notice: Undefined index: plugins/buddypress/bp-members/bp-members-template.php on line 1162

[tw2113]

I can definitely see this happening, since this is the line in question:

$data = apply_filters( 'bp_get_member_profile_data_' . $profile_data[ $r['field'] ]['field_type'], $data, $r );

No isset checks at that point. Logically, in those cases, it's going to produce a filter name of bp_get_member_profile_data_ without anything after the trailing _

That said, it's hard to say if we want to try and default to a specific value or perhaps return early with a false value?

[hnla]

Lets bring it in to 2.9 and get a second-opinion of fix then.

[r-a-y]

01.patch should fix this up.

[tw2113]

Do we perhaps want to change it to have a filter of bp_get_member_profile_data by default and then conditionally append the rest?

$filter = 'bp_get_member_profile_data';
if ( ! empty( $profile_data[ $r['field'] ]['field_type'] ) ) { 
    $filter .= "_{$profile_data[ $r['field'] ]['field_type']}";
}
$data = apply_filters( $filter, $data, $r )

This way, it at least gets "bp_get_member_profile_data" available as a filter. Just a thought.

[r-a-y]

There's already a 'bp_get_member_profile_data' filter right above the dynamic one :)

[tw2113]

Ah, well played. I see nothing wrong with this then.

[r-a-y]

In 11588:

Members: Avoid a notice if an invalid field is passed in bp_member_profile_data().

Props seventhqueen.

Fixes #7516.