bp_group_has_members performs unnecessary query

[brandonliles]

The function bp_group_has_members defaults the query parameter 'search_terms' to null when there are no search terms, but BP_User_Query expects that 'search_terms' is false rather than null. This results in BP_User_Query issuing an unnecessary table scan on the users table.

[dcavins]

Hi @brandonliles-

Thanks for finding this inefficiency! In reading the documentation for the function, it looks like fixing it is slightly more complicated than first thought.

$search_terms - Optional. Search terms to match. Pass an empty string to force-disable search, even in the presence of $_REQUEST[s].

The key part of your patch is that search_terms => false is passed to BP_Groups_Group_Members_Template so that ultimately BP_User_Query stops doing

WHERE ( user_login LIKE '%%'
OR user_login LIKE '%%'
OR user_nicename LIKE '%%'
OR user_nicename LIKE '%%' ) ) )

all the time. I've added some logic to make sure that our documentation is observed while keeping the core of your patch.

Great find!

-David

[dcavins]

Respect that a dev can force-disable search by passing a search_term of .

[dcavins]

In 11595:

Correct search_term parameter in bp_group_has_members().

The function bp_group_has_members() defaults the query parameter
search_terms to null when there are no search terms, but
BP_User_Query expects search_terms to be false rather than null
when a search is not needed.

Props brandonliles.

Fixes #7513.