Skip to:
Content

Opened 8 months ago

Closed 7 months ago

#7494 closed enhancement (fixed)

Take advantage of BP_Groups_Group magic methods in groups component setup

Reported by: dcavins Owned by: dcavins
Milestone: 2.9 Priority: normal
Severity: normal Version: 1.6
Component: Groups Keywords: has-patch dev-feedback
Cc: dcavins

Description

During single group setup in the BP Groups Component, we're doing some checks that duplicate logic done in BP_Groups_Group. We can take advantage of some of the recent work in BP_Groups_Group and simplify the single group setup.

Attachments (1)

7494.1.diff (4.1 KB) - added by dcavins 8 months ago.
Add $is_visible and $is_user_member properties to BP_Groups_Group object. Use magic methods in BP Groups Component single group setup.

Download all attachments as: .zip

Change History (5)

@dcavins
8 months ago

Add $is_visible and $is_user_member properties to BP_Groups_Group object. Use magic methods in BP Groups Component single group setup.

#1 @dcavins
8 months ago

  • Owner set to dcavins
  • Status changed from new to accepted

This ticket was mentioned in Slack in #buddypress by dcavins. View the logs.


8 months ago

This ticket was mentioned in Slack in #buddypress by dcavins. View the logs.


7 months ago

#4 @dcavins
7 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 11544:

Add $is_visible and $is_user_member properties to BP_Groups_Group object.

During single group setup in the BP_Groups_Component, we're doing
some checks that duplicate logic that is, or should be, handled in
BP_Groups_Group. Then, BP_Groups_Component can rely on
BP_Groups_Group to provide the details via recently added magic
methods.

Note: $is_user_member is an alias of $is_member for backward
compatibility.

Fixes #7494.

Note: See TracTickets for help on using tickets.