Skip to:
Content

BuddyPress.org

Opened 8 years ago

Closed 8 years ago

#7460 closed defect (bug) (fixed)

Remove unwanted code for `Index hint`

Reported by: vishalkakadiya's profile vishalkakadiya Owned by: boonebgorges's profile boonebgorges
Milestone: 2.9 Priority: normal
Severity: normal Version: 2.8.0
Component: Activity Keywords: has-patch
Cc:

Description

Some code was added for USE INDEX in buddypress 1.6.0, check on ​https://buddypress.trac.wordpress.org/attachment/ticket/4045/4045.02.diff

Then it was decided that not need to use USE INDEX for several reasons, please check that on ​https://buddypress.trac.wordpress.org/ticket/5448

After 5448 ticket USE INDEX was removed from the query but the other code which is added for that $index_hint_sql is not removed, please check that on ​https://github.com/buddypress/BuddyPress/commit/635e817f89e23e1f6459b7823647c7d13d95a267

I am removing that unwanted code and adding my patch.

Attachments (1)

7460.patch​ (1.2 KB) - added by vishalkakadiya 8 years ago.

Download all attachments as: .zip

Change History (3)

@vishalkakadiya
8 years ago

#1 @boonebgorges
8 years ago

  • Milestone changed from Awaiting Review to 2.9

Good catch! Thanks for the patch, @vishalkakadiya.

#2 @boonebgorges
8 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 11516:

Remove unnecessary USE INDEX clause building in BP_Activity_Activity.

The resulting clause was unused since [8071].

Props vishalkakadiya.
Fixes #7460.

Note: See TracTickets for help on using tickets.