Incorrect Format of apply_filters_ref_array for bp_get_group_name within class-bp-groups-list-table.php

[garrett-eclipse]

Hello,

I noticed this issue as I was adding a filter for bp_get_group_name and expecting 2 parameters but got an error on the Groups listing caused by the incorrect format of apply_filters_ref_array for bp_get_group_name within class-bp-groups-list-table.php;
​https://github.com/buddypress/BuddyPress/blob/master/src/bp-groups/classes/class-bp-groups-list-table.php#L523

<?php
$group_name = apply_filters_ref_array( 'bp_get_group_name', array( $item['name'] ), $item );

This is invalid as apply_filters_ref_array only supports two params the second being an array, the above provides three params.

Code should have the $item within the array, this will allow filters to receive both attributes properly.

Correct Code;

<?php
$group_name = apply_filters_ref_array( 'bp_get_group_name', array( $item['name'], $item ) );

*The $group param was added in 2.5 for the bp_get_group_name filter in the above code $item is the group.

Thank you

[DJPaul]

yep, good spot.

[1naveengiri]

I added that argument in correct place in this patch.

[1naveengiri]

Hi @DJPaul,

will you please take a look. if all right in this patch please accept it. because the issue is something which errors and it should get fixed in BuddyPress asap.

[boonebgorges]

In 11440:

Fix incorrect apply_filters_ref_array() syntax.

Introduced in [8426].

Props garrett-eclipse, 1naveengiri.
Fixes #7420.

[boonebgorges]

In 11441:

Fix incorrect apply_filters_ref_array() syntax.

Introduced in [8426].

Ports [11440] to the 2.8 branch.

Props garrett-eclipse, 1naveengiri.
Fixes #7420.