Action request: cover image deleted

[jdgrimes]

There is an action ("{$object_data['component']}_cover_image_uploaded") that fires in bp_attachments_cover_image_ajax_upload(), and there should be a complementary one in bp_attachments_cover_image_ajax_delete(). Otherwise it is possible to do something when a cover image is uploaded, but not to reverse any of the effects when the cover image is deleted.

[jdgrimes]

Adds the deleted action

[jdgrimes]

Correct the copy-pasted action arg description

[jdgrimes]

I've uploaded 7409-2.diff​ as a first pass.

[slaFFik]

As an idea.
What about the difference in approaches:

do_action( "{$component}_cover_image_deleted", (int) $cover_image_data['item_id'] );
vs
do_action( "bp_component_cover_image_deleted", (int) $cover_image_data['item_id'], $component );

Personally I would go with the second one, as it will allow much easier targeting in a hook of all components that have cover image deleted.
Currently in a patch by @jdgrimes we need to get the list of components, and among them those that are using cover images to be able to target ANY covers deletion. That's a lot of extra work where it's easy to make a mistake.

[boonebgorges]

I agree with @slaFFik that we should generally avoid dynamic action/filter names, as they're harder to read and harder to document. The one time they're really advantageous is when a hook might be fired very, very frequently; in this case, it's better for performance to avoid invoking extra callbacks. The case of deleting a cover image isn't one of these instances.

That being said, if we already have a dynamic hook name for updating, we should probably do the same thing for deletion, just for the sake of consistency.

[jdgrimes]

Replying to boonebgorges:

That being said, if we already have a dynamic hook name for updating, we should probably do the same thing for deletion, just for the sake of consistency.

Yes, I was just following the pattern of the "{$object_data['component']}_cover_image_uploaded" action.

[boonebgorges]

In 11357:

Fire an action when a cover image is deleted.

The new {$component}_cover_image_deleted action provides
parity with the existing {$component}_cover_image_uploaded
action.

Props jdgrimes.
Fixes #7409.