Skip to:
Content

BuddyPress.org

Opened 3 years ago

Closed 3 years ago

#7373 closed defect (bug) (fixed)

Member Types directory not available when Members is the front-page

Reported by: slaFFik Owned by: boonebgorges
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.3.0
Component: Members Keywords: needs-patch
Cc:

Description

1) Create several member types (using Codex example: https://codex.buddypress.org/developer/member-types/)
2) Assign in wp-admin area some types to different users.
3) Make sure you have for example blog posts displayed on your home page - visiting member type URL like /members/type/students will give you proper results.
4) Got to Settings -> Reading and make Members WP page as a home page
5) Now when visiting member types directory you will redirected to a home page. It's impossible now to open a member type directory page.
/type/students returns 404 as expected.

If member dir is made a home page we should either:
1) make /type/students URL work as a member type directory
2) regardless of what is set as a home page - always make /members/type/students URL work as a member type directory.

Change History (4)

#1 @slaFFik
3 years ago

  • Version set to 2.3.0

@boonebgorges
As you are the author of most of the code regarding Member Types, will you be able to take a look at this?

#2 @boonebgorges
3 years ago

  • Owner set to boonebgorges
  • Status changed from new to assigned

Good find. Your option (2) sounds like the correct path forward to me.

#3 @slaFFik
3 years ago

  • Milestone changed from Future Release to 2.8

Targeting for 2.8, but lets see/try.

#4 @boonebgorges
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 11281:

When determining canonical URL, consider member type directories when 'page_on_front'.

bp_get_canonical_url() has some special logic for when
'page_on_front' is a BP component directory. This logic was introduced
before member and group type directories, so it did not account for
them.

The current changeset ensures that URLs of the format
example.com/members/type/foo do not redirect to example.com when
the Members directory is set to the home page.

The same problem doesn't arise for group type directories, because
the component/action stack works differently in the case of groups.

Fixes #7373.

Note: See TracTickets for help on using tickets.