Skip to:
Content

BuddyPress.org

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#7236 closed defect (bug) (fixed)

Comments in Groups can not be deleted

Reported by: danielhuesken Owned by: r-a-y
Milestone: 2.7 Priority: normal
Severity: normal Version: 1.5
Component: Activity Keywords:
Cc:

Description

We have a spceil site configuration (network/actifity) and than comments in groups can't be deleted because the link is false.

That can be fixed if you switch the function bp_get_activity_slug() to bp_get_activity_root_slug() in bp_get_activity_comment_delete_link() https://buddypress.trac.wordpress.org/browser/trunk/src/bp-activity/bp-activity-template.php#L2100

Change History (5)

#1 follow-up: @DJPaul
3 years ago

  • Milestone changed from Awaiting Review to 2.7

Thanks for creating a ticket, @danielhuesken.

Looking at that function next to bp_activity_get_permalink, it does look like this method should be using the root_slug function, not the other one (which I think is intended for .com/user/activity/). Can someone just sanity check my understanding, and I'll go ahead and make the change?

#2 in reply to: ↑ 1 @boonebgorges
3 years ago

Replying to DJPaul:

Thanks for creating a ticket, @danielhuesken.

Looking at that function next to bp_activity_get_permalink, it does look like this method should be using the root_slug function, not the other one (which I think is intended for .com/user/activity/). Can someone just sanity check my understanding, and I'll go ahead and make the change?

Yup, looks right to me.

#3 @r-a-y
3 years ago

Even better, use bp_get_activity_directory_permalink().

#4 @r-a-y
3 years ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 11066:

Activity: Fix activity comment delete link when Activity Directory page is nested.

Fixes #7236.

Props danielhuesken.

#5 @r-a-y
3 years ago

  • Version changed from 2.6.2 to 1.5
Note: See TracTickets for help on using tickets.