Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#7153 closed defect (bug) (fixed)

Fatal error on BuddyPress 2.6.1 activation (from repo)

Reported by: svenl77 Owned by: djpaul
Milestone: 2.6.1.1 Priority: omg pizza
Severity: critical Version: 2.6.0
Component: Core Keywords: needs-patch
Cc:

Description

If I install BuddyPress form wordpress.org on a fresh install I get the following error:

​*Fatal error: Class 'BP_Members_Component' not found in /Users/svenl77/Sites/buddyforms/wp-content/plugins/buddypress/bp-members/bp-members-loader.php on line 23*​

It looks like the .org version is broken

Attachments (3)

7153.01.patch (780 bytes) - added by DJPaul 4 years ago.
7153-alt.01.patch (764 bytes) - added by DJPaul 4 years ago.
alt
7153-alt.02.patch (770 bytes) - added by DJPaul 4 years ago.
alt

Download all attachments as: .zip

Change History (13)

#1 @slaFFik
4 years ago

  • Severity changed from normal to critical
  • Summary changed from BuddyPress Version 1.6.1 on WordPress.org Fatal error: Class 'BP_Members_Component' to Fatal error on BuddyPress 2.6.1 activation (from repo)
  • Version set to 2.6.0

#2 @slaFFik
4 years ago

Installing 2.6.1 from repo breaks the site.
Upgrading from 2.6 to 2.6.1 works fine.
Installing 2.6 works fine.

#3 @DJPaul
4 years ago

  • Priority changed from high to omg pizza

#4 @slaFFik
4 years ago

Seems it was introduced in [10918].

Last edited 4 years ago by slaFFik (previous) (diff)

#5 @slaFFik
4 years ago

Commenting out those lines from a changeset fixes the error. Seems the error is because members component not yet init'ed on activation.

Last edited 4 years ago by slaFFik (previous) (diff)

@DJPaul
4 years ago

@DJPaul
4 years ago

alt

@DJPaul
4 years ago

alt

#6 @slaFFik
4 years ago

  • Milestone changed from Awaiting Review to 2.6.1.1

#7 @djpaul
4 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 10928:

Core: Fix class autoloader behaviour during new installations.

This change for the 2.6 branch adds members to the component whitelist within our autoloader implementation.

In r10918, we improved the class autoloader logic introduced in #6853 to support third-party plugins doing class_exists() checks for disabled components. However, new installations of BuddyPress still trigger fatal errors because we missed that the members component is always loaded, not just the core component.

Fixes #7153

Props DJPaul, slaFFik, offereins, mercime, svenl77, scharc, tomas711.

#8 @imath
4 years ago

@djpaul & all,

Thanks for catching and fixing this bug so quickly.
I guess this should also be committed to trunk ?

#9 @slaFFik
4 years ago

I believe, after testing, yeah.

#10 @djpaul
4 years ago

In 10942:

Core: Fix class autoloader behaviour during new installations.

This change for trunk adds members to the component whitelist within our autoloader implementation.

In r10918, we improved the class autoloader logic introduced in #6853 to support third-party plugins doing class_exists() checks for disabled components. However, new installations of BuddyPress still trigger fatal errors because we missed that the members component is always loaded, not just the core component.

Fixes #7153

Props DJPaul, slaFFik, offereins, mercime, svenl77, scharc, tomas711.

Note: See TracTickets for help on using tickets.