User queries using the 'bp_pre_user_query_construct' action to filter 'member_type' return all members instead matching members.

[rekmla]

We're attempting to set query_vars['member_type'] using the 'bp_pre_user_query_construct' action. All members are being returned, not just members with a specific member type. I've traced the problem to the function get_sql_clause_for_member_types() in the class BP_User_Query which is failing to preg_match the where clause of the intermediate taxonomy query this function performs. Said where clause has a leading 'AND' and is wrapped in '()' which is not accounted for in the regex used when converting this clause to a subquery.

A second issue found is that restore_current_blog() happens too early resulting in the wrong $wpdb->term_relationships value being used in this optimization.

[rekmla]

Oddly, I cannot recreate the problem I had with a null return value for the function get_sql_clause_for_member_types().

However, the second issue - restore_current_blog() happening in too early is still true.

Patch adjusted accordingly.

[rekmla]

Simplified patch

[rekmla]

Update on recreating this issue. This is a similar issue to the issue reported in ​https://buddypress.trac.wordpress.org/ticket/7144.

This issue occurs when using the 'bp_get_taxonomy_term_site_id' filter to override the default table location for the 'bp_member_type' taxonomy.

All members are being returned, not just members with a specific member type. I've traced the problem to the function get_sql_clause_for_member_types() in the class BP_User_Query which is failing to preg_match the where clause of the intermediate taxonomy query this function performs. The match is failing if the value of $wpdb->term_relationships is different than the value at the time the taxonomy query is generated.

This is because restore_current_blog() happens too early resulting in the wrong $wpdb->term_relationships value being used in the match.

[r-a-y]

Thanks for the proposed fix and for your investigation, @rekmla.

This sounds right to me. If you are able to, if you are able to write a unit test that triggers this problem, your fix will be committed faster.

[r-a-y]

In 10912:

Taxonomy: Fix usage of restore_current_blog() when using bp_get_taxonomy_term_site_id().

See #7077 where we introduced bp_get_taxonomy_term_site_id().

Props remkla.

Fixes #7142, #7144 (2.6-branch).

[r-a-y]

In 10913:

Taxonomy: Fix usage of restore_current_blog() when using bp_get_taxonomy_term_site_id().

See #7077 where we introduced bp_get_taxonomy_term_site_id().

Props remkla.

Fixes #7142, #7144 (trunk).