Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 10 years ago

#7136 closed defect (bug) (fixed)

Escaping group link and group title attribute in cover image header

Reported by: imath Owned by: imath
Priority: normal Milestone: 2.6
Component: Groups Version:
Severity: normal Keywords: has-patch commit
Cc:

Description

This changeset r10777 escaped the href and title attribute of the group's link. But it hasn't been done on the cover-image-header.php.

It seems to me we should also do it in 2.6, because it's by default the header used for groups unless cover images has been deactivated.

Attachments (1)

7136.patch​ (983 bytes ) - added by imath 10 years ago.

Download all attachments as: .zip

Change History (6)

@imath
10 years ago

This ticket was mentioned in ​Slack in #buddypress by imath. ​View the logs.
10 years ago

#2 @r-a-y
10 years ago

+1 from me here.

This ticket was mentioned in ​Slack in #buddypress by dcavins. ​View the logs.
10 years ago

#4 @imath
10 years ago

  • Keywords commit added

Thanks a lot for your feedback @r-a-y I'm going to commit it.

#5 @imath
10 years ago

  • Owner set to imath
  • Resolution → fixed
  • Status new → closed

In 10892:

Improve escaping in cover-image-header.php template.

Fixes #7136

Note: See TracTickets for help on using tickets.