Skip to:
Content

BuddyPress.org

Opened 3 years ago

Closed 3 years ago

#7124 closed defect (bug) (fixed)

bp_locate_template_asset() should use the theme compat dir and theme compat url

Reported by: imath Owned by: imath
Milestone: 2.6 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch commit
Cc:

Description

@r-a-y when doing the replace thing, the $data['uri'] is not good for a symlinked/custom template pack. Just tested with BP Nouveau.

I think using bp_get_theme_compat_dir() & bp_get_theme_compat_url() would work for any template pack (including BP Legacy).

It's working for BP Nouveau ;)

As you only use $data['file'] to include the embed css inline there's no big deal, but it makes the bp_locate_template_asset() unusable for other assets.

See attached patch.

Attachments (1)

7124.patch (542 bytes) - added by imath 3 years ago.

Download all attachments as: .zip

Change History (4)

@imath
3 years ago

#1 @r-a-y
3 years ago

  • Keywords commit added

+1.

Commit at will! :)

#2 @imath
3 years ago

  • Milestone changed from Under Consideration to 2.6

I'll do it asap :)

#3 @imath
3 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 10889:

Make sure any template pack can use bp_locate_template_asset()

Fixes #7124

Note: See TracTickets for help on using tickets.