Skip to:
Content

BuddyPress.org

Opened 3 years ago

Closed 3 years ago

#7118 closed defect (bug) (fixed)

[BP Nouveau Request] Unlike other components the Blogs component don't have a bp_get_blogs_pagination_count() function

Reported by: imath Owned by: imath
Milestone: 2.7 Priority: normal
Severity: normal Version:
Component: Blogs Keywords: has-patch commit
Cc:

Description

Working on the BP Nouveau template pack, i've noticed there's only a bp_blogs_pagination_count() we would also need a bp_get_blogs_pagination_count() to get the content.

In the meantime we are doing a ob_start(), ob_get_clean()...

Attachments (1)

7118.patch (1.5 KB) - added by imath 3 years ago.

Download all attachments as: .zip

Change History (11)

#1 @DJPaul
3 years ago

  • Milestone changed from Under Consideration to Awaiting Review

#2 @imath
3 years ago

  • Summary changed from Unlike other components the Blogs component don't have a bp_get_blogs_pagination_count() function to [BP Nouveau Request] Unlike other components the Blogs component don't have a bp_get_blogs_pagination_count() function

#3 @DJPaul
3 years ago

  • Milestone changed from Awaiting Review to Future Release

This ticket was mentioned in Slack in #buddypress by djpaul. View the logs.


3 years ago

#5 @imath
3 years ago

  • Milestone changed from Future Release to 2.7
  • Owner set to imath
  • Status changed from new to assigned

#6 @johnjamesjacoby
3 years ago

+1. @imath do you want to work together to make Blogs great again?

#7 @imath
3 years ago

@johnjamesjacoby sure that's my 2.7´s goal :)

@imath
3 years ago

#8 @imath
3 years ago

  • Keywords has-patch added; needs-patch good-first-bug removed

If no objections, i will commit 7118.patch in a few hours.

#9 @johnjamesjacoby
3 years ago

  • Keywords commit added

Go for it.

#10 @imath
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 10906:

Blogs: introduce a function to return the blogs pagination

Unlike other components, the blogs component was not including a function to only return the pagination content, but only a function to display it.
bp_get_blogs_pagination_count() will now do this job and the bp_blogs_pagination_count() is using it to display the pagination.

Fixes #7118

Note: See TracTickets for help on using tickets.