Skip to:
Content

BuddyPress.org

Opened 3 years ago

Closed 3 years ago

#7107 closed defect (bug) (fixed)

Spammed activity comment is cross-posted to a WP post as a regular comment

Reported by: r-a-y Owned by: r-a-y
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.0
Component: Blogs Keywords: has-patch commit
Cc:

Description

In testing #6719, @hnla found that if activity post synchronization is on, spammed activity comments are cross-posted as regular WP post comments.

We probably should not create a WP post comment if the activity comment is marked as spam.

Attached patch includes a fix for this and a unit test.

Attachments (1)

7107.01.patch (2.6 KB) - added by r-a-y 3 years ago.

Download all attachments as: .zip

Change History (7)

@r-a-y
3 years ago

#1 @DJPaul
3 years ago

  • Keywords commit added

Looks good

#2 @imath
3 years ago

  • Keywords commit removed

i'd say the patch looks good, but at the same time i think spam is also used when a comment or post is trashed...

#3 @imath
3 years ago

  • Keywords commit added

oops didn't mean to remove Paul's keyword :)

#4 @r-a-y
3 years ago

but at the same time i think spam is also used when a comment or post is trashed...

I think this makes sense if a user is posting a WordPress comment. This patch doesn't touch that.

When a user posts from within the BuddyPress activity stream, we control what happens before we decide to sync a comment to a WordPress post.

#5 @imath
3 years ago

Good point! Go ahead :)

#6 @r-a-y
3 years ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 10854:

Blogs: Do not create a post comment if the related activity comment is marked as spam.

Props hnla, r-a-y.

Fixes #7107.

Note: See TracTickets for help on using tickets.