Skip to:
Content

BuddyPress.org

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#7072 closed defect (bug)

Filter error in buddypress

Reported by: harimay's profile harimay Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: Priority: normal
Severity: normal Version: 2.5.0
Component: BuddyPress.org Sites Keywords:
Cc:

Description

There is an small error on the buddypress
please kindly check with this filter "bp_messages_single_new_message_notification"

File and Line number
buddypress plugin buddypress\bp-messages\bp-messages-notifications.php
Line number 155

The filter action contain the 7 variable of which "$link" are callaed twice this filter is being generated dynamically with the number of message send and received

The documentation is being writer on the same page

<code>
/

  • Filters the new message notification text before the notification is created. *
  • This is a dynamic filter. Possible filter names are:
  • - 'bp_messages_multiple_new_message_notification'.
  • - 'bp_messages_single_new_message_notification'. *
  • @param string $retval Notification text.
  • @param int $total_items Number of messages referred to by the notification.
  • @param string $text The raw notification test (ie, not wrapped in a link).
  • @param int $item_id ID of the associated item.
  • @param int $secondary_item_id ID of the secondary associated item. */

</code>

Attachments (1)

bp-messages-notifications.php (8.9 KB) - added by harimay 8 years ago.
After making the filter Proper

Download all attachments as: .zip

Change History (2)

@harimay
8 years ago

After making the filter Proper

#1 @johnjamesjacoby
8 years ago

  • Milestone BuddyPress.org deleted
  • Status changed from new to closed

Hi harimay, thanks for the ticket (and for noticing this odd bit of code.)

It looks like this was already fixed as part of #6750, in [10706].


The bp_messages_single_new_message_notification filter was one of the only ones that had an odd number of parameters passed into it, so it needed to be handled in a special way.

Since this was already addressed, I'm closing this issue as a duplicate, and it will work correctly in the next BuddyPress release.

Thanks again for your help in reporting things like this; we really appreciate it!

Last edited 8 years ago by johnjamesjacoby (previous) (diff)
Note: See TracTickets for help on using tickets.